diff mbox series

[24/35] libxl: Remove libxl__qmp_run_command_flexarray

Message ID 20190802153606.32061-25-anthony.perard@citrix.com (mailing list archive)
State Superseded
Headers show
Series libxl refactoring to use ev_qmp (with API changes) | expand

Commit Message

Anthony PERARD Aug. 2, 2019, 3:35 p.m. UTC
There are no more users.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libxl/libxl_internal.h |  3 ---
 tools/libxl/libxl_qmp.c      | 16 ----------------
 2 files changed, 19 deletions(-)

Comments

Ian Jackson Sept. 17, 2019, 5:14 p.m. UTC | #1
Anthony PERARD writes ("[PATCH 24/35] libxl: Remove libxl__qmp_run_command_flexarray"):
> There are no more users.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff mbox series

Patch

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 8dea44b221..5c15a73a08 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1979,9 +1979,6 @@  typedef struct libxl__qmp_handler libxl__qmp_handler;
  */
 _hidden libxl__qmp_handler *libxl__qmp_initialize(libxl__gc *gc,
                                                   uint32_t domid);
-_hidden int libxl__qmp_run_command_flexarray(libxl__gc *gc, int domid,
-                                             const char *cmd,
-                                             flexarray_t *array);
 _hidden int libxl__qmp_pci_add(libxl__gc *gc, int d, libxl_device_pci *pcidev);
 _hidden int libxl__qmp_pci_del(libxl__gc *gc, int domid,
                                libxl_device_pci *pcidev);
diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index 0d6aedcc7d..c78ef4637d 100644
--- a/tools/libxl/libxl_qmp.c
+++ b/tools/libxl/libxl_qmp.c
@@ -833,22 +833,6 @@  static int qmp_run_command(libxl__gc *gc, int domid,
     return rc;
 }
 
-int libxl__qmp_run_command_flexarray(libxl__gc *gc, int domid,
-                                     const char *cmd, flexarray_t *array)
-{
-    libxl__json_object *args = NULL;
-    int i;
-    void *name, *value;
-
-    for (i = 0; i < array->count; i += 2) {
-        flexarray_get(array, i, &name);
-        flexarray_get(array, i + 1, &value);
-        libxl__qmp_param_add_string(gc, &args, (char *)name, (char *)value);
-    }
-
-    return qmp_run_command(gc, domid, cmd, args, NULL, NULL);
-}
-
 int libxl__qmp_pci_add(libxl__gc *gc, int domid, libxl_device_pci *pcidev)
 {
     libxl__qmp_handler *qmp = NULL;