| Message ID | 20191014142246.4538-3-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw: Clean up hw/i386 headers (and few alpha/hppa) | expand |
On 10/14/19 10:22 AM, Philippe Mathieu-Daudé wrote: > The ICH9 chipset is not X86/PC specific. > > These files don't use anything declared by the "hw/i386/pc.h" > or "hw/i386/ioapic.h" headers. Remove them. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> > --- > hw/acpi/ich9.c | 1 - > hw/isa/lpc_ich9.c | 2 -- > include/hw/i386/ich9.h | 1 - > 3 files changed, 4 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index 2034dd749e..fdd0a6c79e 100644 > --- a/hw/acpi/ich9.c > +++ b/hw/acpi/ich9.c > @@ -27,7 +27,6 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qapi/visitor.h" > -#include "hw/i386/pc.h" > #include "hw/pci/pci.h" > #include "migration/vmstate.h" > #include "qemu/timer.h" > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c > index 17c292e306..61cee2ae3a 100644 > --- a/hw/isa/lpc_ich9.c > +++ b/hw/isa/lpc_ich9.c > @@ -35,10 +35,8 @@ > #include "hw/isa/isa.h" > #include "hw/sysbus.h" > #include "migration/vmstate.h" > -#include "hw/i386/pc.h" > #include "hw/irq.h" > #include "hw/isa/apm.h" > -#include "hw/i386/ioapic.h" > #include "hw/pci/pci.h" > #include "hw/pci/pci_bridge.h" > #include "hw/i386/ich9.h" > diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h > index 72e803f6e2..a98d10b252 100644 > --- a/include/hw/i386/ich9.h > +++ b/include/hw/i386/ich9.h > @@ -5,7 +5,6 @@ > #include "hw/sysbus.h" > #include "hw/i386/pc.h" > #include "hw/isa/apm.h" > -#include "hw/i386/ioapic.h" > #include "hw/pci/pci.h" > #include "hw/pci/pcie_host.h" > #include "hw/pci/pci_bridge.h" >
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 2034dd749e..fdd0a6c79e 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -27,7 +27,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qapi/visitor.h" -#include "hw/i386/pc.h" #include "hw/pci/pci.h" #include "migration/vmstate.h" #include "qemu/timer.h" diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 17c292e306..61cee2ae3a 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -35,10 +35,8 @@ #include "hw/isa/isa.h" #include "hw/sysbus.h" #include "migration/vmstate.h" -#include "hw/i386/pc.h" #include "hw/irq.h" #include "hw/isa/apm.h" -#include "hw/i386/ioapic.h" #include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" #include "hw/i386/ich9.h" diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index 72e803f6e2..a98d10b252 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -5,7 +5,6 @@ #include "hw/sysbus.h" #include "hw/i386/pc.h" #include "hw/isa/apm.h" -#include "hw/i386/ioapic.h" #include "hw/pci/pci.h" #include "hw/pci/pcie_host.h" #include "hw/pci/pci_bridge.h"
The ICH9 chipset is not X86/PC specific. These files don't use anything declared by the "hw/i386/pc.h" or "hw/i386/ioapic.h" headers. Remove them. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/acpi/ich9.c | 1 - hw/isa/lpc_ich9.c | 2 -- include/hw/i386/ich9.h | 1 - 3 files changed, 4 deletions(-)