| Message ID | 20191022125006.3746-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 34fbb76d009dcf4275f53b51296d96dc09236bb7 |
| Headers | show |
| Series | xen: mm: include <xen/xen-ops.h> for missing declarations | expand |
On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote: > Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region > call declarations. Fixes the following sparse warnings: > > arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? > arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: Russell King <linux@armlinux.org.uk> > Cc: xen-devel@lists.xenproject.org > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/xen/mm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c > index 38fa917c8585..6feb6b78b13c 100644 > --- a/arch/arm/xen/mm.c > +++ b/arch/arm/xen/mm.c > @@ -15,6 +15,7 @@ > #include <xen/interface/grant_table.h> > #include <xen/interface/memory.h> > #include <xen/page.h> > +#include <xen/xen-ops.h> > #include <xen/swiotlb-xen.h> > > #include <asm/cacheflush.h> > -- > 2.23.0 >
On Tue, 22 Oct 2019, Stefano Stabellini wrote: > On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote: > > Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region > > call declarations. Fixes the following sparse warnings: > > > > arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? > > arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? > > > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Do you want me to pick up these two patches and have them go upstream via the Xen tree, or are they part of a bigger rework?
On 22/10/2019 18:09, Stefano Stabellini wrote: > On Tue, 22 Oct 2019, Stefano Stabellini wrote: >> On Tue, 22 Oct 2019, Ben Dooks (Codethink) wrote: >>> Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region >>> call declarations. Fixes the following sparse warnings: >>> >>> arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? >>> arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? >>> >>> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> >> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > Do you want me to pick up these two patches and have them go upstream > via the Xen tree, or are they part of a bigger rework? I've been doing some testing with sparse and going fixing warnings as I go along. Please take these via your tree.
diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 38fa917c8585..6feb6b78b13c 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -15,6 +15,7 @@ #include <xen/interface/grant_table.h> #include <xen/interface/memory.h> #include <xen/page.h> +#include <xen/xen-ops.h> #include <xen/swiotlb-xen.h> #include <asm/cacheflush.h>
Include <xen/xen-ops.h> for xen_{create,destroy}_contigous_region call declarations. Fixes the following sparse warnings: arch/arm/xen/mm.c:119:5: warning: symbol 'xen_create_contiguous_region' was not declared. Should it be static? arch/arm/xen/mm.c:131:6: warning: symbol 'xen_destroy_contiguous_region' was not declared. Should it be static? Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Russell King <linux@armlinux.org.uk> Cc: xen-devel@lists.xenproject.org Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/xen/mm.c | 1 + 1 file changed, 1 insertion(+)