From patchwork Fri Nov 29 11:28:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 11267019 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EB9A6921 for ; Fri, 29 Nov 2019 11:31:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7DAA20833 for ; Fri, 29 Nov 2019 11:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="bhwbMKrT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7DAA20833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaeT3-0006qp-Ep; Fri, 29 Nov 2019 11:29:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iaeT1-0006qe-MX for xen-devel@lists.xenproject.org; Fri, 29 Nov 2019 11:29:43 +0000 X-Inumbo-ID: 86dca29c-129b-11ea-a3e3-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 86dca29c-129b-11ea-a3e3-12813bfff9fa; Fri, 29 Nov 2019 11:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1575026978; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sQ0XLdjh/Fs15+1JwkEDWJDg2qfluPMHMfcwwCyy4mY=; b=bhwbMKrT4iVjKbjV0xXd29lolkUgWM+Tnrswl1LTpR4IJBLKn3BpksEu CPvu/c0CYYRC0a6ghIXcmGLygNE1G7K9439hleycWSahxx4HsWoeNUfil iSsxhz74iBlt2HWSeRJtqgLbUpmJgBlSJ5gPJEDciPEMruIczSjbEzGWz I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: ZMGsBGbObLOagAGMhhjG7px077dS92xMJBYi92JzuOK4OptHn3Q8lwi6VPy7ZXOoIak6EjNdFP gna21/8r9t/prTk3E15+UTMJ3DD3hZAFnKn6tY6vAGZZyoorH6+xSjiXWqmF2F8aWHsMKN0HNx xj/Hc0QQFLJcJfBvh0EdBjhSKmiIFM1lz3jaL3n8dTOp877qkNIFJBWhiz3jooXKoBbzI4VU5h AefPx81BElZ2Qnc8PRbHvE63jMXXit79rhUTSIZYVogb8OVWGbk/Kia+uuUCyfG3PLH3A2pZLm epQ= X-SBRS: 2.7 X-MesageID: 9338026 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,257,1571716800"; d="scan'208";a="9338026" From: Roger Pau Monne To: Date: Fri, 29 Nov 2019 12:28:49 +0100 Message-ID: <20191129112851.19273-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191129112851.19273-1-roger.pau@citrix.com> References: <20191129112851.19273-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2 2/4] x86/apic: force phys mode if interrupt remapping is disabled X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Cluster mode can only be used with interrupt remapping support, since the top 16bits of the APIC ID are filled with the cluster ID, and hence on systems where the physical ID is still smaller than 255 the cluster ID is not. Force x2APIC to use physical mode if there's no interrupt remapping support. Note that this requires a further patch in order to enable x2APIC without interrupt remapping support. Signed-off-by: Roger Pau Monné --- Changes since v1: - New in this version. --- xen/arch/x86/genapic/x2apic.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c index d5a17f10d5..7e32ee22ff 100644 --- a/xen/arch/x86/genapic/x2apic.c +++ b/xen/arch/x86/genapic/x2apic.c @@ -228,6 +228,14 @@ const struct genapic *__init apic_x2apic_probe(void) if ( x2apic_phys < 0 ) x2apic_phys = !!(acpi_gbl_FADT.flags & ACPI_FADT_APIC_PHYSICAL); + if ( !x2apic_phys && !iommu_intremap ) + /* + * Force physical mode if there's no interrupt remapping support: the + * ID in clustered mode requires a 32 bit destination field due to the + * usage of the high 16 bits to store the cluster ID. + */ + x2apic_phys = true; + if ( x2apic_phys ) return &apic_x2apic_phys;