From patchwork Thu Dec 12 18:27:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 11289065 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 439B5109A for ; Thu, 12 Dec 2019 18:29:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20F5A2253D for ; Thu, 12 Dec 2019 18:29:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="Fs+ZeWfa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20F5A2253D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ifTCK-0007OL-Vv; Thu, 12 Dec 2019 18:28:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ifTCK-0007O2-Gt for xen-devel@lists.xenproject.org; Thu, 12 Dec 2019 18:28:24 +0000 X-Inumbo-ID: 249a062a-1d0d-11ea-b6f1-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 249a062a-1d0d-11ea-b6f1-bc764e2007e4; Thu, 12 Dec 2019 18:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1576175288; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zymFI7Z+q9SwVxzuaeFtT9HknAP1x6eJXTTlRZkHS0o=; b=Fs+ZeWfa/x06Dc+34v7CnsYYRPndh0Dtz2k8fMzGTE4LgxKSOEGXNAfz x3v8KJmE4TKVFuT7ccd7OD5zBBxAaYYi8xImutKUv3cn/SEH/LotKyLBZ +8Ap9+XTFhlc2D86r+lFAsJ43juEPnLqQmh7HPaf0SGsrTomZfI8zAXeR o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: hnzUuT+m70w0MDxjY80mRwxwXxLiDKveThik7DYxkH7/RJ+avvfmcQ2xwP4zImkwM/ILOMfJ2G L+DMo6Zxoyz9CQJofiWoYfw2GvNj4bkNjdjIbz74juSt59Ce87fICRP5DCe0H9VeMhr1p7xdXD yvDEOF3ba6KZNht8YVV9hTGnB+KsP3Vmex6H9rFp7oSsQQ8EGTVkzSQgE0Vqb216c2WRfNBbWt 3ruzz5GEu13Enxn4tgSoZ6VWxEP19A3bjLeRMq7rXbqPtSPRxqfe07XD05+Yzri3ZSiPqdP9tA tCw= X-SBRS: 2.7 X-MesageID: 9611969 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.69,306,1571716800"; d="scan'208";a="9611969" From: Anthony PERARD To: Date: Thu, 12 Dec 2019 18:27:34 +0000 Message-ID: <20191212182740.2190199-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191212182740.2190199-1-anthony.perard@citrix.com> References: <20191212182740.2190199-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [XEN PATCH 2/8] Config.mk: Remove stray comment X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , Anthony PERARD Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This comment isn't about CONFIG_TESTS, but about SEABIOS_DIR that has been removed. Originally, the comment was added by 5f82d0858de1 ("tools: support SeaBIOS. Use by default when upstream qemu is configured."), then later the SEABIOS_DIR was removed by 14ee3c05f3ef ("Clone and build Seabios by default") but that comment about the pain was left behind. The commit that made CONFIG_TESTS painful was 85896a7c4dc7 ("build: add autoconf to replace custom checks in tools/check"). Let the comment rest, event if CONFIG_TESTS=y can be painful. It's enabled by default anyway and doesn't cause pain for most configuration. Signed-off-by: Anthony PERARD --- Config.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/Config.mk b/Config.mk index 8768398d5ece..35d66e5e121a 100644 --- a/Config.mk +++ b/Config.mk @@ -289,7 +289,4 @@ QEMU_TRADITIONAL_LOC ?= $(call or,$(wildcard $(QEMU_TRADITIONAL_INTREE)),\ QEMU_UPSTREAM_LOC ?= $(call or,$(wildcard $(QEMU_UPSTREAM_INTREE)),\ $(QEMU_UPSTREAM_URL)) -# Short answer -- do not enable this unless you know what you are -# doing and are prepared for some pain. - CONFIG_TESTS ?= y