| Message ID | 20191213161753.8051-10-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h' | expand |
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > Since commit 0c8465440 the ioapic_print_redtbl() function is not > used outside of ioapic_common.c, make it static, and remove its > prototype declaration in "ioapic_internal.h". > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/hw/i386/ioapic_internal.h | 1 - > hw/intc/ioapic_common.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/hw/i386/ioapic_internal.h b/include/hw/i386/ioapic_internal.h > index d46c87c510..8b743aeed0 100644 > --- a/include/hw/i386/ioapic_internal.h > +++ b/include/hw/i386/ioapic_internal.h > @@ -118,7 +118,6 @@ struct IOAPICCommonState { > > void ioapic_reset_common(DeviceState *dev); > > -void ioapic_print_redtbl(Monitor *mon, IOAPICCommonState *s); > void ioapic_stat_update_irq(IOAPICCommonState *s, int irq, int level); > > #endif /* QEMU_IOAPIC_INTERNAL_H */ > diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c > index 5538b5b86e..72ea945377 100644 > --- a/hw/intc/ioapic_common.c > +++ b/hw/intc/ioapic_common.c > @@ -76,7 +76,7 @@ static void ioapic_irr_dump(Monitor *mon, const char *name, uint32_t bitmap) > monitor_printf(mon, "\n"); > } > > -void ioapic_print_redtbl(Monitor *mon, IOAPICCommonState *s) > +static void ioapic_print_redtbl(Monitor *mon, IOAPICCommonState *s) > { > static const char *delm_str[] = { > "fixed", "lowest", "SMI", "...", "NMI", "INIT", "...", "extINT"}; > Queued, thanks. Paolo
diff --git a/include/hw/i386/ioapic_internal.h b/include/hw/i386/ioapic_internal.h index d46c87c510..8b743aeed0 100644 --- a/include/hw/i386/ioapic_internal.h +++ b/include/hw/i386/ioapic_internal.h @@ -118,7 +118,6 @@ struct IOAPICCommonState { void ioapic_reset_common(DeviceState *dev); -void ioapic_print_redtbl(Monitor *mon, IOAPICCommonState *s); void ioapic_stat_update_irq(IOAPICCommonState *s, int irq, int level); #endif /* QEMU_IOAPIC_INTERNAL_H */ diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c index 5538b5b86e..72ea945377 100644 --- a/hw/intc/ioapic_common.c +++ b/hw/intc/ioapic_common.c @@ -76,7 +76,7 @@ static void ioapic_irr_dump(Monitor *mon, const char *name, uint32_t bitmap) monitor_printf(mon, "\n"); } -void ioapic_print_redtbl(Monitor *mon, IOAPICCommonState *s) +static void ioapic_print_redtbl(Monitor *mon, IOAPICCommonState *s) { static const char *delm_str[] = { "fixed", "lowest", "SMI", "...", "NMI", "INIT", "...", "extINT"};
Since commit 0c8465440 the ioapic_print_redtbl() function is not used outside of ioapic_common.c, make it static, and remove its prototype declaration in "ioapic_internal.h". Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- include/hw/i386/ioapic_internal.h | 1 - hw/intc/ioapic_common.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)