From patchwork Wed Feb 26 12:46:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 11406437 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2AEEE930 for ; Wed, 26 Feb 2020 12:48:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FAB321927 for ; Wed, 26 Feb 2020 12:48:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FAB321927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6w5n-0002Ah-06; Wed, 26 Feb 2020 12:47:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6w5l-0002AX-KR for xen-devel@lists.xenproject.org; Wed, 26 Feb 2020 12:47:09 +0000 X-Inumbo-ID: 19ab1564-5896-11ea-a490-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19ab1564-5896-11ea-a490-bc764e2007e4; Wed, 26 Feb 2020 12:47:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B2508AC6E; Wed, 26 Feb 2020 12:47:07 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Wed, 26 Feb 2020 13:46:54 +0100 Message-Id: <20200226124705.29212-2-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200226124705.29212-1-jgross@suse.com> References: <20200226124705.29212-1-jgross@suse.com> Subject: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , Konrad Rzeszutek Wilk , Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich , =?utf-8?q?Roger_Pau_Monn=C3=A9?= MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Support of other variable sizes than that of normal bool ones for boolean_parameter() don't make sense, so catch any other sized variables at build time. Fix the one parameter using a plain int instead of bool. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V6: - new patch --- xen/arch/x86/hvm/asid.c | 2 +- xen/include/xen/param.h | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/asid.c b/xen/arch/x86/hvm/asid.c index 8e00a28443..8b5bb86dfd 100644 --- a/xen/arch/x86/hvm/asid.c +++ b/xen/arch/x86/hvm/asid.c @@ -25,7 +25,7 @@ #include /* Xen command-line option to enable ASIDs */ -static int opt_asid_enabled = 1; +static bool opt_asid_enabled = true; boolean_param("asid", opt_asid_enabled); /* diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h index 75471eb4ad..d4578cd27f 100644 --- a/xen/include/xen/param.h +++ b/xen/include/xen/param.h @@ -2,6 +2,8 @@ #define _XEN_PARAM_H #include +#include +#include /* * Used for kernel command line parameter setup @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __kparam __setup_##_var = \ { .name = __setup_str_##_var, \ .type = OPT_BOOL, \ - .len = sizeof(_var), \ + .len = sizeof(_var) + \ + BUILD_BUG_ON_ZERO(sizeof(_var) != sizeof(bool)), \ .par.var = &_var } #define integer_param(_name, _var) \ __setup_str __setup_str_##_var[] = _name; \ @@ -86,7 +89,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __rtparam __rtpar_##_var = \ { .name = _name, \ .type = OPT_BOOL, \ - .len = sizeof(_var), \ + .len = sizeof(_var) + \ + BUILD_BUG_ON_ZERO(sizeof(_var) != sizeof(bool)), \ .par.var = &_var } #define integer_runtime_only_param(_name, _var) \ __rtparam __rtpar_##_var = \