diff mbox series

tools/helpers: xen-init-dom0: Mark clear_domid_history() static

Message ID 20200312202407.1154-1-julien@xen.org (mailing list archive)
State New, archived
Headers show
Series tools/helpers: xen-init-dom0: Mark clear_domid_history() static | expand

Commit Message

Julien Grall March 12, 2020, 8:24 p.m. UTC 
From: Julien Grall <jgrall@amazon.com>

xen-init-dom0 is a standalone binary, so all the functions but the
main() should be static.

Signed-off-by: Julien Grall <jgrall@amazon.com>
Cc: paul@xen.org
---
 tools/helpers/xen-init-dom0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wei Liu March 13, 2020, 10:06 a.m. UTC | #1 
On Thu, Mar 12, 2020 at 08:24:07PM +0000, julien@xen.org wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> xen-init-dom0 is a standalone binary, so all the functions but the
> main() should be static.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Acked-by: Wei Liu <wl@xen.org>
Paul Durrant March 13, 2020, 12:09 p.m. UTC | #2 
> -----Original Message-----
> From: julien@xen.org <julien@xen.org>
> Sent: 12 March 2020 20:24
> To: xen-devel@lists.xenproject.org
> Cc: Julien Grall <jgrall@amazon.com>; Ian Jackson <ian.jackson@eu.citrix.com>; Wei Liu <wl@xen.org>;
> paul@xen.org
> Subject: [PATCH] tools/helpers: xen-init-dom0: Mark clear_domid_history() static
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> xen-init-dom0 is a standalone binary, so all the functions but the
> main() should be static.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> Cc: paul@xen.org

Reviewed-by: Paul Durrant <paul@xen.org>
diff mbox series

Patch

diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index 56f69ab66f..c99224a4b6 100644
--- a/tools/helpers/xen-init-dom0.c
+++ b/tools/helpers/xen-init-dom0.c
@@ -12,7 +12,7 @@ 
 #define DOMNAME_PATH   "/local/domain/0/name"
 #define DOMID_PATH     "/local/domain/0/domid"
 
-int clear_domid_history(void)
+static int clear_domid_history(void)
 {
     int rc = 1;
     xentoollog_logger_stdiostream *logger;