From patchwork Fri Apr 17 22:16:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 11496185 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B5CE913 for ; Fri, 17 Apr 2020 22:18:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37FCC2137B for ; Fri, 17 Apr 2020 22:18:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rCo8cU3h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37FCC2137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jPZHR-0006fb-Mt; Fri, 17 Apr 2020 22:16:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jPZHQ-0006fW-E3 for xen-devel@lists.xenproject.org; Fri, 17 Apr 2020 22:16:12 +0000 X-Inumbo-ID: 0b924700-80f9-11ea-b58d-bc764e2007e4 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0b924700-80f9-11ea-b58d-bc764e2007e4; Fri, 17 Apr 2020 22:16:12 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F32220656; Fri, 17 Apr 2020 22:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587161771; bh=gb3Z9a2VrqqwohrS52ctiZQwXXCEVwx1D9sYthQAaBA=; h=From:To:Cc:Subject:Date:From; b=rCo8cU3hxVvD+j2afiY73LvWzbGWr81CAXYZXvJloPVc2WLXNBApK7OE1L8avdFAu DM8KWKwmgCfsD2KZ3vYgRsfIt/CrbWkqXsG45TJeqZEOnVFGmiMHcLDVdX6VQRY3xc s6OMUUMjpT/MvOXkqSuevESQd9B7FDK1UYj2wDVQ= From: Stefano Stabellini To: julien@xen.org Subject: [PATCH][RESEND] xen/arm: vgic-v3: fix GICD_ISACTIVER range Date: Fri, 17 Apr 2020 15:16:09 -0700 Message-Id: <20200417221609.19928-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Peng Fan , sstabellini@kernel.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Peng Fan The end should be GICD_ISACTIVERN not GICD_ISACTIVER. (See https://marc.info/?l=xen-devel&m=158527653730795 for a discussion on what it would take to implement GICD_ISACTIVER/GICD_ICACTIVER properly.) Signed-off-by: Peng Fan Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini Acked-by: Julien Grall --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 4e60ba15cc..fd8cfc156d 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -713,7 +713,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v, goto read_as_zero; /* Read the active status of an IRQ via GICD/GICR is not supported */ - case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVER): + case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN): case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN): goto read_as_zero;