| Message ID | 20200529162234.16824-1-tamas@tklengyel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0 | expand |
On 29/05/2020 17:22, Tamas K Lengyel wrote: > The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a > boolean. This is incorrect and breaks external-only usecases of altp2m that > is set with a value of 2. > > Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> Sorry for breaking it to begin with.
Andrew Cooper writes ("Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0"):
> On 29/05/2020 17:22, Tamas K Lengyel wrote:
> > The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a
> > boolean. This is incorrect and breaks external-only usecases of altp2m that
> > is set with a value of 2.
> >
> > Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Sorry for breaking it to begin with.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
and pushed.
On Fri, May 29, 2020 at 10:32 AM Ian Jackson <ian.jackson@citrix.com> wrote: > > Andrew Cooper writes ("Re: [PATCH v2 for-4.14] tools/libxl: fix setting altp2m param broken by 1e9bc407cf0"): > > On 29/05/2020 17:22, Tamas K Lengyel wrote: > > > The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a > > > boolean. This is incorrect and breaks external-only usecases of altp2m that > > > is set with a value of 2. > > > > > > Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com> > > > > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> > > > > Sorry for breaking it to begin with. > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > > and pushed. Thanks for the fast turn around. Tamas
diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index f8bc828e62..e57f63282e 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -391,7 +391,7 @@ static int hvm_set_conf_params(libxl__gc *gc, uint32_t domid, libxl_ctx *ctx = libxl__gc_owner(gc); xc_interface *xch = ctx->xch; int ret = ERROR_FAIL; - bool altp2m = info->altp2m; + unsigned int altp2m = info->altp2m; switch(info->type) { case LIBXL_DOMAIN_TYPE_HVM:
The patch 1e9bc407cf0 mistakenly converted the altp2m config option to a boolean. This is incorrect and breaks external-only usecases of altp2m that is set with a value of 2. Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com> --- v2: just convert bool to unsigned int --- tools/libxl/libxl_x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)