| Message ID | 20200608160044.15531-18-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/qdev: Warn when using pre-qdev/QOM devices | expand |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/input/pckbd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c > index 60a4130320..c7f42be63b 100644 > --- a/hw/input/pckbd.c > +++ b/hw/input/pckbd.c > @@ -31,7 +31,7 @@ > #include "hw/input/i8042.h" > #include "sysemu/reset.h" > #include "sysemu/runstate.h" > - > +#include "hw/qdev-deprecated.h" > #include "trace.h" > > /* Keyboard Controller Commands */ > @@ -467,6 +467,8 @@ void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq, > { > KBDState *s = g_malloc0(sizeof(KBDState)); > > + qdev_warn_deprecated_function_used(); > + > s->irq_kbd = kbd_irq; > s->irq_mouse = mouse_irq; > s->mask = mask; > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> The ISA variant is QOM-ified, but you placed the warning in the right place. Paolo
diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 60a4130320..c7f42be63b 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -31,7 +31,7 @@ #include "hw/input/i8042.h" #include "sysemu/reset.h" #include "sysemu/runstate.h" - +#include "hw/qdev-deprecated.h" #include "trace.h" /* Keyboard Controller Commands */ @@ -467,6 +467,8 @@ void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq, { KBDState *s = g_malloc0(sizeof(KBDState)); + qdev_warn_deprecated_function_used(); + s->irq_kbd = kbd_irq; s->irq_mouse = mouse_irq; s->mask = mask;
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/input/pckbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)