From patchwork Mon Jun 8 16:00:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11593509 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9313A90 for ; Mon, 8 Jun 2020 16:03:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E16E206A4 for ; Mon, 8 Jun 2020 16:03:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fp3ELPSt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E16E206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiKEG-0004Uj-B3; Mon, 08 Jun 2020 16:02:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiKEF-0004U4-Jb for xen-devel@lists.xenproject.org; Mon, 08 Jun 2020 16:02:27 +0000 X-Inumbo-ID: 72ea2460-a9a1-11ea-b292-12813bfff9fa Received: from us-smtp-delivery-1.mimecast.com (unknown [205.139.110.120]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 72ea2460-a9a1-11ea-b292-12813bfff9fa; Mon, 08 Jun 2020 16:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591632147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rWjAvYJiR2Vce0nRqDWV8FQMXBd2aTRIKVfGqqqeffM=; b=Fp3ELPStTjOuCI2wh3Qr1TxUN+zTA1lS6oawlpuxmNGFJPlQRZwuKuXedi5PKnlf/ijE01 RwYWOHNOOW4vESN2GPUueV8V7Ox8+YRINfCOpDu1PedOV7M9UCIC2Zkm/vclokoeIzlOIb JzgEh7DdVApaLHtoL1g1lgUtvtaPjY8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-kdrXROYUNHy98U8QiL-WeQ-1; Mon, 08 Jun 2020 12:02:25 -0400 X-MC-Unique: kdrXROYUNHy98U8QiL-WeQ-1 Received: by mail-wm1-f69.google.com with SMTP id r1so5962wmh.7 for ; Mon, 08 Jun 2020 09:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rWjAvYJiR2Vce0nRqDWV8FQMXBd2aTRIKVfGqqqeffM=; b=BKJzTd6SUBqDrkRvvW8UhZlryW17ahOLVvlLN/oDGddqM7tz9XmLWCncMp4Z7V2XV0 nH9STxTX8x7T+VVpMSdDwTYPyKgErySkvmi5RrddfIoGLVC/W5mQ5DV7glDel8POnz/d LPE2gnQzEDDLXGUCGSw2mIDOcNC8AallSvh2rUCVSzpb68YNosDPj+bgYXEWp8nyIbVU oYfadF+ILtLtj8aEpN8mj91kGrU+RLjmJmpODA7t9ZYkKTb0Qf5Cp69Z0KvZtefUWUgn CRxIeG5d/OzpXpvFCCMeEmJEfpmV3abfgmH+hfa57A6k0slK8lYfADK0Us+IUbJfkLvc 3oCg== X-Gm-Message-State: AOAM530pRpGBJD/eQnGUtfUP8NpHIgBTKN6RrA86DGtZFcHxlf8fgV+f j6qlmnkSSswmE2zSM+uHAtYGtkOUUEW9oVT1e/Cl0O/oxVPLZrTZr0Se7zzvq+FDWIlmecH4BDx AIV70QgW0RYaMwaPjmiidCWE3Vs8= X-Received: by 2002:a5d:4987:: with SMTP id r7mr23761277wrq.316.1591632143873; Mon, 08 Jun 2020 09:02:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8yfQfybue0LoXzyzfK8+trtOuK8e4qLitwG3WzemMauiha6gB9njX0C0ZNjvkq/B156qsJg== X-Received: by 2002:a5d:4987:: with SMTP id r7mr23761254wrq.316.1591632143730; Mon, 08 Jun 2020 09:02:23 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id s8sm142543wrm.96.2020.06.08.09.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:02:23 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used Date: Mon, 8 Jun 2020 18:00:26 +0200 Message-Id: <20200608160044.15531-18-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608160044.15531-1-philmd@redhat.com> References: <20200608160044.15531-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Mark Cave-Ayland , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Paul Durrant , Magnus Damm , Markus Armbruster , Marcel Apfelbaum , Anthony Perard , =?utf-8?q?Marc-Andr=C3=A9_Lurea?= =?utf-8?q?u?= , David Gibson , Andrzej Zaborowski , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Stafford Horne , Palmer Dabbelt , Richard Henderson , "Daniel P . Berrange" , Thomas Huth , Bastian Koppelmann , =?utf-8?q?Philippe_Mat?= =?utf-8?q?hieu-Daud=C3=A9?= , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini --- hw/input/pckbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 60a4130320..c7f42be63b 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -31,7 +31,7 @@ #include "hw/input/i8042.h" #include "sysemu/reset.h" #include "sysemu/runstate.h" - +#include "hw/qdev-deprecated.h" #include "trace.h" /* Keyboard Controller Commands */ @@ -467,6 +467,8 @@ void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq, { KBDState *s = g_malloc0(sizeof(KBDState)); + qdev_warn_deprecated_function_used(); + s->irq_kbd = kbd_irq; s->irq_mouse = mouse_irq; s->mask = mask;