| Message ID | 20200608160044.15531-30-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/qdev: Warn when using pre-qdev/QOM devices | expand |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/ppc/ppc_booke.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c > index 652a21b806..a9e5e68578 100644 > --- a/hw/ppc/ppc_booke.c > +++ b/hw/ppc/ppc_booke.c > @@ -31,7 +31,7 @@ > #include "qemu/log.h" > #include "hw/loader.h" > #include "kvm_ppc.h" > - > +#include "hw/qdev-deprecated.h" > > /* Timer Control Register */ > > @@ -338,6 +338,8 @@ void ppc_booke_timers_init(PowerPCCPU *cpu, uint32_t freq, uint32_t flags) > booke_timer_t *booke_timer; > int ret = 0; > > + qdev_warn_deprecated_function_used(); > + > tb_env = g_malloc0(sizeof(ppc_tb_t)); > booke_timer = g_malloc0(sizeof(booke_timer_t)); > > This one is okay. Paolo
diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c index 652a21b806..a9e5e68578 100644 --- a/hw/ppc/ppc_booke.c +++ b/hw/ppc/ppc_booke.c @@ -31,7 +31,7 @@ #include "qemu/log.h" #include "hw/loader.h" #include "kvm_ppc.h" - +#include "hw/qdev-deprecated.h" /* Timer Control Register */ @@ -338,6 +338,8 @@ void ppc_booke_timers_init(PowerPCCPU *cpu, uint32_t freq, uint32_t flags) booke_timer_t *booke_timer; int ret = 0; + qdev_warn_deprecated_function_used(); + tb_env = g_malloc0(sizeof(ppc_tb_t)); booke_timer = g_malloc0(sizeof(booke_timer_t));
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/ppc/ppc_booke.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)