| Message ID | 20200608160044.15531-7-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/qdev: Warn when using pre-qdev/QOM devices | expand |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/timer/arm_timer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c > index 9607366d78..e23e6b4b31 100644 > --- a/hw/timer/arm_timer.c > +++ b/hw/timer/arm_timer.c > @@ -16,6 +16,7 @@ > #include "hw/qdev-properties.h" > #include "qemu/module.h" > #include "qemu/log.h" > +#include "hw/qdev-deprecated.h" > > /* Common timer implementation. */ > > @@ -175,6 +176,8 @@ static arm_timer_state *arm_timer_init(uint32_t freq) > { > arm_timer_state *s; > > + qdev_warn_deprecated_function_used(); > + > s = (arm_timer_state *)g_malloc0(sizeof(arm_timer_state)); > s->freq = freq; > s->control = TIMER_CTRL_IE; > This one is okay, the devices that use arm_timer_init are all QOM. Paolo
diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c index 9607366d78..e23e6b4b31 100644 --- a/hw/timer/arm_timer.c +++ b/hw/timer/arm_timer.c @@ -16,6 +16,7 @@ #include "hw/qdev-properties.h" #include "qemu/module.h" #include "qemu/log.h" +#include "hw/qdev-deprecated.h" /* Common timer implementation. */ @@ -175,6 +176,8 @@ static arm_timer_state *arm_timer_init(uint32_t freq) { arm_timer_state *s; + qdev_warn_deprecated_function_used(); + s = (arm_timer_state *)g_malloc0(sizeof(arm_timer_state)); s->freq = freq; s->control = TIMER_CTRL_IE;
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/timer/arm_timer.c | 3 +++ 1 file changed, 3 insertions(+)