From patchwork Sat Jul 18 03:32:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elliott Mitchell X-Patchwork-Id: 11671577 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7BA213B6 for ; Sat, 18 Jul 2020 04:19:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A0EC2076A for ; Sat, 18 Jul 2020 04:19:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A0EC2076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=m5p.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jweIJ-0005k5-VM; Sat, 18 Jul 2020 04:17:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jweIJ-0005k0-1K for xen-devel@lists.xen.org; Sat, 18 Jul 2020 04:17:51 +0000 X-Inumbo-ID: a34d57aa-c8ad-11ea-96f0-12813bfff9fa Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a34d57aa-c8ad-11ea-96f0-12813bfff9fa; Sat, 18 Jul 2020 04:17:48 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.15.2/8.15.2) with ESMTPS id 06I3WgY1088890 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 17 Jul 2020 23:32:48 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.15.2/8.15.2/Submit) id 06I3Wgfh088889; Fri, 17 Jul 2020 20:32:42 -0700 (PDT) (envelope-from ehem) Date: Fri, 17 Jul 2020 20:32:42 -0700 From: Elliott Mitchell To: xen-devel@lists.xen.org Subject: [PATCH 2/2] tools/ocaml: Default to useful build output Message-ID: <20200718033242.GB88869@mattapan.m5p.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mattapan.m5p.com X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: ian.jackson@eu.citrix.com, christian.lindig@citrix.com, wl@xen.org, dave@recoil.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" While hiding details of build output looks pretty to some, defaulting to doing so deviates from the rest of Xen. Switch the OCAML tools to match everything else. Signed-off-by: Elliott Mitchell --- Time for a bit of controversy. Presently the OCAML tools build mismatches the rest of the Xen build. My choice is to default to verbose output. While some may like beauty in their build output, function is far more important. If someone wants to take on the task of making Xen's build output consistently beatiful, invite them to do so. Then call the police and tell them you're being robbed. --- tools/ocaml/Makefile.rules | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules index a893c42b43..abfbc64ce0 100644 --- a/tools/ocaml/Makefile.rules +++ b/tools/ocaml/Makefile.rules @@ -1,17 +1,20 @@ ifdef V - ifeq ("$(origin V)", "command line") - BUILD_VERBOSE = $(V) - endif + ifeq ("$(origin V)", "command line") + BUILD_VERBOSE = $(V) + endif +else + V := 1 + BUILD_VERBOSE := 1 endif ifndef BUILD_VERBOSE - BUILD_VERBOSE = 0 + BUILD_VERBOSE := 0 endif ifeq ($(BUILD_VERBOSE),1) - E = @true - Q = + E := @true + Q := else - E = @echo - Q = @ + E := @echo + Q := @ endif .NOTPARALLEL: