From patchwork Wed Oct 7 17:59:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11821503 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C17717D2 for ; Wed, 7 Oct 2020 18:28:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D15C821775 for ; Wed, 7 Oct 2020 18:28:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D15C821775 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.3689.10834 (Exim 4.92) (envelope-from ) id 1kQE9e-0001oJ-Hb; Wed, 07 Oct 2020 18:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 3689.10834; Wed, 07 Oct 2020 18:27:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kQE9d-0001n3-Kz; Wed, 07 Oct 2020 18:27:09 +0000 Received: by outflank-mailman (input) for mailman id 3689; Wed, 07 Oct 2020 18:27:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kQE6E-00072Q-QR for xen-devel@lists.xenproject.org; Wed, 07 Oct 2020 18:23:38 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f2b79de9-1655-40fe-9954-e6f3aa7c5974; Wed, 07 Oct 2020 18:21:33 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kQDjx-0007CF-P2; Wed, 07 Oct 2020 19:00:37 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kQE6E-00072Q-QR for xen-devel@lists.xenproject.org; Wed, 07 Oct 2020 18:23:38 +0000 X-Inumbo-ID: f2b79de9-1655-40fe-9954-e6f3aa7c5974 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f2b79de9-1655-40fe-9954-e6f3aa7c5974; Wed, 07 Oct 2020 18:21:33 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kQDjx-0007CF-P2; Wed, 07 Oct 2020 19:00:37 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson , Ian Jackson Subject: [OSSTEST PATCH 18/82] host allocation: Remove some unnecessary definedness tests Date: Wed, 7 Oct 2020 18:59:20 +0100 Message-Id: <20201007180024.7932-19-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201007180024.7932-1-iwj@xenproject.org> References: <20201007180024.7932-1-iwj@xenproject.org> MIME-Version: 1.0 From: Ian Jackson $set_info->() already checkes for undef, and returns immediately in that case. So there is no point checking at the call site. No functional change. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index f17e7b70..5d71d08c 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -849,15 +849,8 @@ sub alloc_resources { $set_info->('sub-priority',$ENV{OSSTEST_RESOURCE_SUBPRIORITY}); $set_info->('preinfo', $ENV{OSSTEST_RESOURCE_PREINFO}); $set_info->('feature-noalloc', 1); - - if (defined $waitstart) { - $set_info->('wait-start',$waitstart); - } - - my $adjust= $xparams{WaitStartAdjust}; - if (defined $adjust) { - $set_info->('wait-start-adjust',$adjust); - } + $set_info->('wait-start',$waitstart); + $set_info->('wait-start-adjust',$xparams{WaitStartAdjust}); my $jobinfo= $xparams{JobInfo}; if (!defined $jobinfo and defined $flight and defined $job) {