[OSSTEST,61/82] runvar access: Introduce sharing_for_build

Commit Message

Ian Jackson Oct. 7, 2020, 6 p.m. UTC

From: Ian Jackson <[e-mail]>

Builds don't have so much contingent setup.  We don't track the
runvars; we just rely on the share-* hostflag set in the job.

But selecthost() is going to automatically enable runvar access
control for shared/reused hosts.  So, provide a way to disable that.

Signed-off-by: Ian Jackson <[e-mail]>
---
 Osstest/TestSupport.pm | 4 +++-
 ts-host-install        | 2 ++
 ts-xen-build-prep      | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

Patch

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 6403e52b..c6bd6714 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -143,7 +143,7 @@  BEGIN {
                       sha256file host_shared_mark_ready
                       gitcache_setup
 
-		      @accessible_runvar_pats
+		      @accessible_runvar_pats sharing_for_build
                       );
     %EXPORT_TAGS = ( );
 
@@ -3171,6 +3171,8 @@  END
                                  'home-osstest-gitconfig');
 }
 
+sub sharing_for_build () { @accessible_runvar_pats = qw(*); };
+
 sub runvar_access_restrict () {
     # restricts runvars to those in @accessible_runvar_pats
     return if "@accessible_runvar_pats" eq "*";
diff --git a/ts-host-install b/ts-host-install
index b0fd2028..5badc706 100755
--- a/ts-host-install
+++ b/ts-host-install
@@ -49,6 +49,8 @@  while (@ARGV and $ARGV[0] =~ m/^-/) {
     }
 }
 
+if ($build) { sharing_for_build(); }
+
 our ($whhost) = @ARGV;
 $whhost ||= 'host';
 our $ho= selecthost($whhost);
diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index 092bbffe..fcabf75a 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -24,6 +24,7 @@  use Osstest::TestSupport;
 use Osstest::Debian;
 
 tsreadconfig();
+sharing_for_build();
 
 our ($whhost) = @ARGV;
 $whhost ||= 'host';