| Message ID | 20201111082658.3401686-2-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [01/24] block: remove the call to __invalidate_device in check_disk_size_change | expand |
On 11/11/20 9:26 AM, Christoph Hellwig wrote: > __invalidate_device without the kill_dirty parameter just invalidates > various clean entries in caches, which doesn't really help us with > anything, but can cause all kinds of horrible lock orders due to how > it calls into the file system. The only reason this hasn't been a > major issue is because so many people use partitions, for which no > invalidation was performed anyway. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > fs/block_dev.c | 6 ------ > 1 file changed, 6 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/fs/block_dev.c b/fs/block_dev.c index 9e84b1928b9401..66ebf594c97f47 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1334,12 +1334,6 @@ static void check_disk_size_change(struct gendisk *disk, i_size_write(bdev->bd_inode, disk_size); } spin_unlock(&bdev->bd_size_lock); - - if (bdev_size > disk_size) { - if (__invalidate_device(bdev, false)) - pr_warn("VFS: busy inodes on resized disk %s\n", - disk->disk_name); - } } /**
__invalidate_device without the kill_dirty parameter just invalidates various clean entries in caches, which doesn't really help us with anything, but can cause all kinds of horrible lock orders due to how it calls into the file system. The only reason this hasn't been a major issue is because so many people use partitions, for which no invalidation was performed anyway. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/block_dev.c | 6 ------ 1 file changed, 6 deletions(-)