From patchwork Thu Feb 25 17:41:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 12104609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC37C433E6 for ; Thu, 25 Feb 2021 17:42:24 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3A1164F1B for ; Thu, 25 Feb 2021 17:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3A1164F1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.89891.169791 (Exim 4.92) (envelope-from ) id 1lFKeV-00069y-H5; Thu, 25 Feb 2021 17:42:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 89891.169791; Thu, 25 Feb 2021 17:42:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFKeV-00069p-Ck; Thu, 25 Feb 2021 17:42:15 +0000 Received: by outflank-mailman (input) for mailman id 89891; Thu, 25 Feb 2021 17:42:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFKeU-000690-CY for xen-devel@lists.xenproject.org; Thu, 25 Feb 2021 17:42:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFKeT-0005qk-EC; Thu, 25 Feb 2021 17:42:13 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFKeT-00032g-3I; Thu, 25 Feb 2021 17:42:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=AsXl1Pz/JngLBcmlXDlPm3M/+CU4TVWFsS8Ry3xt94k=; b=qIWgFwpRYq59HKUUqTUo+Gbls +bPbBxsbcwnQaXp8Y88/l2MGQ+hjpYH0x3IFMNPsdVzhXnYboqliZC3qdrXnPvuvHwjD6wC6eGYsC VLfHHzToFtXLrgGUHI7eIWU+DoPmXWl4EjxCu1s1eZXOS0HHvw7JvTG82PRo+YSgOtsBU=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 1/5] tools/xenstored: Avoid unnecessary talloc_strdup() in do_control_lu() Date: Thu, 25 Feb 2021 17:41:27 +0000 Message-Id: <20210225174131.10115-2-julien@xen.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210225174131.10115-1-julien@xen.org> References: <20210225174131.10115-1-julien@xen.org> From: Julien Grall At the moment, the return of talloc_strdup() is not checked. This means we may dereference a NULL pointer if the allocation failed. However, it is pointless to allocate the memory as send_reply() will copy the data to a different buffer. So drop the use of talloc_strdup(). This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc. Fixes: fecab256d474 ("tools/xenstore: add basic live-update command parsing") Signed-off-by: Julien Grall Reviewed-by: Juergen Gross --- tools/xenstore/xenstored_control.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index f10beaf85eb4..e8a501acdb62 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -691,7 +691,6 @@ static const char *lu_start(const void *ctx, struct connection *conn, static int do_control_lu(void *ctx, struct connection *conn, char **vec, int num) { - const char *resp; const char *ret = NULL; unsigned int i; bool force = false; @@ -734,8 +733,7 @@ static int do_control_lu(void *ctx, struct connection *conn, if (!ret) ret = "OK"; - resp = talloc_strdup(ctx, ret); - send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); + send_reply(conn, XS_CONTROL, ret, strlen(ret) + 1); return 0; } #endif