| Message ID | 20210628100157.5010-3-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN,1/2] libxl: Replace short-form boolean for QEMU's -vnc | expand |
On Mon, Jun 28, 2021 at 6:02 AM Anthony PERARD <anthony.perard@citrix.com> wrote: > > Usage of 'scsi-disk' device is deprecated and removed from QEMU, > instead we need to use 'scsi-hd' for hard drives. > See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device) > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Reviewed-by: Jason Andryuk <jandryuk@gmail.com> Looks like scsi-hd is really old - qemu v0.15. Regards, Jason
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 7670e403a90f..dbd3c7f278f9 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1972,7 +1972,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, &drive_id), flexarray_vappend(dm_args, "-drive", drive, - "-device", GCSPRINTF("scsi-disk,drive=%s,scsi-id=%d", + "-device", GCSPRINTF("scsi-hd,drive=%s,scsi-id=%d", drive_id, disk), NULL); continue;
Usage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives. See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device) Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libs/light/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)