diff mbox series

[5/7] fat: use sync_blockdev_nowait

Message ID 20211019062530.2174626-6-hch@lst.de (mailing list archive)
State Accepted
Commit cb9568ee755c8289855a7a5ce0e1ee0082eca576
Headers show
Series [1/7] fs: remove __sync_filesystem | expand

Commit Message

Christoph Hellwig Oct. 19, 2021, 6:25 a.m. UTC 
Use sync_blockdev_nowait instead of opencoding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/fat/inode.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Chaitanya Kulkarni Oct. 19, 2021, 6:34 a.m. UTC | #1 
On 10/18/2021 11:25 PM, Christoph Hellwig wrote:
> Use sync_blockdev_nowait instead of opencoding it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
diff mbox series

Patch

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index de0c9b013a851..2fd5bfddb6958 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1943,10 +1943,8 @@  int fat_flush_inodes(struct super_block *sb, struct inode *i1, struct inode *i2)
 		ret = writeback_inode(i1);
 	if (!ret && i2)
 		ret = writeback_inode(i2);
-	if (!ret) {
-		struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
-		ret = filemap_flush(mapping);
-	}
+	if (!ret)
+		ret = sync_blockdev_nowait(sb->s_bdev);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(fat_flush_inodes);