diff mbox series

[v5,02/14] vpci: fix function attributes for vpci_process_pending

Message ID 20211125110251.2877218-3-andr2000@gmail.com (mailing list archive)
State New, archived
Headers show
Series PCI devices passthrough on Arm, part 3 | expand

Commit Message

Oleksandr Andrushchenko Nov. 25, 2021, 11:02 a.m. UTC 
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

vpci_process_pending is defined with different attributes, e.g.
with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
Fix this by defining both of the definitions with __must_check.

Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

---
Cc: Roger Pau Monné <roger.pau@citrix.com>

New in v4
---
 xen/include/xen/vpci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julien Grall Dec. 10, 2021, 5:55 p.m. UTC | #1 
Hi Oleksandr,

On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> vpci_process_pending is defined with different attributes, e.g.
> with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
> Fix this by defining both of the definitions with __must_check.
> 
> Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,
Roger Pau Monné Dec. 11, 2021, 8:20 a.m. UTC | #2 
On Fri, Dec 10, 2021 at 05:55:03PM +0000, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > vpci_process_pending is defined with different attributes, e.g.
> > with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
> > Fix this by defining both of the definitions with __must_check.
> > 
> > Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
> > 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I think this can be committed independently of the rest of the
series?

Thanks, Roger.
Oleksandr Andrushchenko Dec. 11, 2021, 8:57 a.m. UTC | #3 
Hi, Roger!

On 11.12.21 10:20, Roger Pau Monné wrote:
> On Fri, Dec 10, 2021 at 05:55:03PM +0000, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> vpci_process_pending is defined with different attributes, e.g.
>>> with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
>>> Fix this by defining both of the definitions with __must_check.
>>>
>>> Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> Reviewed-by: Julien Grall <jgrall@amazon.com>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>
> I think this can be committed independently of the rest of the
> series?
I think so
>
> Thanks, Roger.
Thank you,
Oleksandr
Oleksandr Andrushchenko Jan. 26, 2022, 8:31 a.m. UTC | #4 
Hi, Roger!

On 11.12.21 10:57, Oleksandr Andrushchenko wrote:
> Hi, Roger!
>
> On 11.12.21 10:20, Roger Pau Monné wrote:
>> On Fri, Dec 10, 2021 at 05:55:03PM +0000, Julien Grall wrote:
>>> Hi Oleksandr,
>>>
>>> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>
>>>> vpci_process_pending is defined with different attributes, e.g.
>>>> with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
>>>> Fix this by defining both of the definitions with __must_check.
>>>>
>>>> Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>> Reviewed-by: Julien Grall <jgrall@amazon.com>
>> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> I think this can be committed independently of the rest of the
>> series?
> I think so
Could you please commit this one, so I don't have to keep it in the v6 of the series?

Thank you in advance,
Oleksandr
>> Thanks, Roger.
> Thank you,
> Oleksandr
Jan Beulich Jan. 26, 2022, 10:54 a.m. UTC | #5 
On 26.01.2022 09:31, Oleksandr Andrushchenko wrote:
> On 11.12.21 10:57, Oleksandr Andrushchenko wrote:
>> On 11.12.21 10:20, Roger Pau Monné wrote:
>>> I think this can be committed independently of the rest of the
>>> series?
>> I think so
> Could you please commit this one, so I don't have to keep it in the v6 of the series?

Did you actually check before asking? See commit 7dc0233f534f from Dec 14th.

Jan
diff mbox series

Patch

diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 9ea66e033f11..3f32de9d7eb3 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -247,7 +247,7 @@  static inline void vpci_write(pci_sbdf_t sbdf, unsigned int reg,
     ASSERT_UNREACHABLE();
 }
 
-static inline bool vpci_process_pending(struct vcpu *v)
+static inline bool __must_check vpci_process_pending(struct vcpu *v)
 {
     ASSERT_UNREACHABLE();
     return false;