| Message ID | 20220130191705.24971-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4564661af6ee321942ec1ab012191d7adedd3e00 |
| Headers | show |
| Series | xen: xenbus_dev.h: delete incorrect file name | expand |
On 30.01.22 20:17, Randy Dunlap wrote: > It is better/preferred not to include file names in source files > because (a) they are not needed and (b) they can be incorrect, > so just delete this incorrect file name. > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: xen-devel@lists.xenproject.org > --- > include/xen/xenbus_dev.h | 1 - > 1 file changed, 1 deletion(-) > > --- linux-next-20220128.orig/include/xen/xenbus_dev.h > +++ linux-next-20220128/include/xen/xenbus_dev.h > @@ -1,5 +1,4 @@ > /****************************************************************************** > - * evtchn.h I think the following line should be deleted, too (can be done while committing). > * > * Interface to /dev/xen/xenbus_backend. > * > Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On 1/30/22 22:46, Juergen Gross wrote: > On 30.01.22 20:17, Randy Dunlap wrote: >> It is better/preferred not to include file names in source files >> because (a) they are not needed and (b) they can be incorrect, >> so just delete this incorrect file name. >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> >> Cc: Juergen Gross <jgross@suse.com> >> Cc: Stefano Stabellini <sstabellini@kernel.org> >> Cc: xen-devel@lists.xenproject.org >> --- >> include/xen/xenbus_dev.h | 1 - >> 1 file changed, 1 deletion(-) >> >> --- linux-next-20220128.orig/include/xen/xenbus_dev.h >> +++ linux-next-20220128/include/xen/xenbus_dev.h >> @@ -1,5 +1,4 @@ >> /****************************************************************************** >> - * evtchn.h > > I think the following line should be deleted, too (can be done while > committing). > Sounds good. Thanks. >> * >> * Interface to /dev/xen/xenbus_backend. >> * >> > > Reviewed-by: Juergen Gross <jgross@suse.com> > > > Juergen
On 30.01.22 20:17, Randy Dunlap wrote: > It is better/preferred not to include file names in source files > because (a) they are not needed and (b) they can be incorrect, > so just delete this incorrect file name. > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Pushed to xen/tip.git for-linus-5.17a Juergen
--- linux-next-20220128.orig/include/xen/xenbus_dev.h +++ linux-next-20220128/include/xen/xenbus_dev.h @@ -1,5 +1,4 @@ /****************************************************************************** - * evtchn.h * * Interface to /dev/xen/xenbus_backend. *
It is better/preferred not to include file names in source files because (a) they are not needed and (b) they can be incorrect, so just delete this incorrect file name. Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: xen-devel@lists.xenproject.org --- include/xen/xenbus_dev.h | 1 - 1 file changed, 1 deletion(-)