From patchwork Mon Feb 28 10:08:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 12762716 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78E90C433EF for ; Mon, 28 Feb 2022 10:08:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.280303.478201 (Exim 4.92) (envelope-from ) id 1nOcwr-0003Jj-FN; Mon, 28 Feb 2022 10:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 280303.478201; Mon, 28 Feb 2022 10:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOcwr-0003Jb-C6; Mon, 28 Feb 2022 10:08:09 +0000 Received: by outflank-mailman (input) for mailman id 280303; Mon, 28 Feb 2022 10:08:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOcwq-0003Hy-1p for xen-devel@lists.xenproject.org; Mon, 28 Feb 2022 10:08:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nOcwp-0002Nm-OP; Mon, 28 Feb 2022 10:08:07 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nOcwp-0004bS-Gg; Mon, 28 Feb 2022 10:08:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=P1oGTBOw5wZOVO0AiBiFv8kLi7uHeyJ9lMmo2PgMCeM=; b=Xooswf XaWMdK16sLCJRRR9stu30FxAnIzYUFWHV+SGKhuuM8yWEzYmHbX7EY1YFDHzm9afT1/KzbnEcuoF+ l0eNhW5CP5P33I/s8g1sVpUVsyNaMgKHMYbpwVpPWgDKCiUS29guJwbeDONAmkSHtqwtceBuP7jmk fd0YErUdet0=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two) Date: Mon, 28 Feb 2022 10:08:05 +0000 Message-Id: <20220228100805.60918-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 From: Julien Grall Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines with ENDPROC") intended to mark all the subroutines with ENDPROC. Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add ENDPROC for the benefits of static analysis tools and the reader. Signed-off-by: Julien Grall Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/arch/arm/arm64/head.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 314b800b3f8e..66d862fc8137 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -800,6 +800,7 @@ ENDPROC(launch) fail: PRINT("- Boot failed -\r\n") 1: wfe b 1b +ENDPROC(fail) GLOBAL(_end_boot) @@ -830,6 +831,7 @@ ENTRY(switch_ttbr) isb ret +ENDPROC(switch_ttbr) #ifdef CONFIG_EARLY_PRINTK /* @@ -847,6 +849,7 @@ init_uart: #endif PRINT("- UART enabled -\r\n") ret +ENDPROC(init_uart) /* Print early debug messages. * x0: Nul-terminated string to print.