From patchwork Mon Apr 25 18:07:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 12826030 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE57FC433EF for ; Mon, 25 Apr 2022 18:08:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.313226.530717 (Exim 4.92) (envelope-from ) id 1nj38K-0000lA-Tk; Mon, 25 Apr 2022 18:08:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 313226.530717; Mon, 25 Apr 2022 18:08:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nj38K-0000l3-Ql; Mon, 25 Apr 2022 18:08:24 +0000 Received: by outflank-mailman (input) for mailman id 313226; Mon, 25 Apr 2022 18:08:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nj38J-0000kx-Uy for xen-devel@lists.xenproject.org; Mon, 25 Apr 2022 18:08:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0afe9ad-c4c2-11ec-a405-831a346695d4; Mon, 25 Apr 2022 20:08:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0afe9ad-c4c2-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1650910101; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tbWrgfjjL76MDqACwCF7hzNlTtB6RXM7lo0C1GDYeNM=; b=EdNUhXykgiazlmQEfNwIDzSpxBzi4W8leZujx+LmkkKeuNoYCOgAvL7h FN44zmDx3NDID914koycCeJJ4yIymUiVvUujTfx87dHICmvzXCiRj3WOh af6YqHs4I0KucadIVG03IjklncAHI/4Eg9keuq3RioBtgf0ifZkjW/Up0 A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 69761879 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:W4Lu5aln1A9UgjP5ZA5VsNHo5gxSJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIWX2HSM/fZZmDzeI8lYd7j901SuJWBx4I2TlE6+Sg2RSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DlWV7V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYdhslboDigvwnCxxSEy9FAKlN4aeEGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3k3ds1zzGS90hRojOWf7i7t5ExjYgwMtJGJ4yY uJHOGUxNUSfMnWjPH8pIrNkxbqwhEC4egdopUy5mLoJuC/cmVkZPL/Fb4OOJ43iqd9utl2Du mvM8mD9AxcbHN+S0zyI9jSrnOCntTz/cJIfEvu/7PECqF+Owm0eDjUGWF39puO24maccd9CL 00f+gI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqu8M7SiYj/ kOYlNPuQzp0ufuaTmz13ruMtjazJSg9JHcPfzMZVhAC58T/oYY1lVTESdMLLUKupoSrQ3eqm WnM9XVgweVI5SIW60ml1W/bj2KBiILRdFYw7AXZZV+h5RphJ7fwMuRE9mPnxfpHKY+YSHyIs 34Fh9WS4YgyMH2dqMCeaL5TRe/0vp5pJBWZ2AcyRMd5q1xB7lb5JehtDCdCyFCF2yruURvge wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNLKigbArLWdrGR2CgmbKggjQfLAEy/1XB HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG82jkEn+ieDPOSTLIVvgDLdoRrpghE9jiF+Lm +uzyuPQk0kPOAEASnS/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp ynVchYBmDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3LE9naMsE 6lZKq1twJ1nE1z6xtjUVrGlxKQKSfhhrVvm0/aNCNTnQ6Ndeg== IronPort-HdrOrdr: A9a23:Q60ka65cJJIcj/OCSgPXwMTXdLJyesId70hD6qhwISY6TiX+rb HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78 hdmtBFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.90,289,1643691600"; d="scan'208";a="69761879" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Daniel De Graaf , Daniel Smith , "George Dunlap" , Jan Beulich , Stefano Stabellini , Wei Liu , "Julien Grall" , =?utf-8?q?Roger_Pau_?= =?utf-8?q?Monn=C3=A9?= Subject: [PATCH] xsm/flask: Fix build with Clang 13 Date: Mon, 25 Apr 2022 19:07:56 +0100 Message-ID: <20220425180756.29738-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Clang 13 chokes with: In file included from xsm/flask/flask_op.c:780: xsm/flask/flask_op.c:698:33: error: passing 4-byte aligned argument to 8-byte aligned parameter 1 of 'flask_ocontext_add' may result in an unaligned pointer access [-Werror,-Walign-mismatch] rv = flask_ocontext_add(&op.u.ocontext); ^ and the same for flask_ocontext_del(). It isn't a problem in practice, because the union always starts 8 bytes into {xen,compat}_flask_op_t, but the diagnostic is based on type alignment alone. struct xen_flask_ocontext has the same layout between native and compat, but does change alignment because of uint64_t, and there is only a native implementation of flask_ocontext_add(). Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Daniel Smith CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Roger Pau Monné Slightly RFC because there don't appear to be any good options here. --- xen/include/public/xsm/flask_op.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/xsm/flask_op.h b/xen/include/public/xsm/flask_op.h index b41dd6dac894..80dc35122320 100644 --- a/xen/include/public/xsm/flask_op.h +++ b/xen/include/public/xsm/flask_op.h @@ -146,7 +146,7 @@ struct xen_flask_ocontext { uint32_t ocon; uint32_t sid; uint64_t low, high; -}; +} __attribute__((__aligned__(8))); typedef struct xen_flask_ocontext xen_flask_ocontext_t; struct xen_flask_peersid {