From patchwork Wed Apr 27 09:49:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Orzel X-Patchwork-Id: 12828525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C5ABC433EF for ; Wed, 27 Apr 2022 09:50:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.314684.532911 (Exim 4.92) (envelope-from ) id 1njeJA-0001Ib-52; Wed, 27 Apr 2022 09:50:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 314684.532911; Wed, 27 Apr 2022 09:50:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ9-0001IA-W4; Wed, 27 Apr 2022 09:50:03 +0000 Received: by outflank-mailman (input) for mailman id 314684; Wed, 27 Apr 2022 09:50:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1njeJ8-00085x-Ps for xen-devel@lists.xenproject.org; Wed, 27 Apr 2022 09:50:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 683cf94c-c60f-11ec-a405-831a346695d4; Wed, 27 Apr 2022 11:50:02 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E6EA14BF; Wed, 27 Apr 2022 02:50:01 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.13.174]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 525183F774; Wed, 27 Apr 2022 02:50:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 683cf94c-c60f-11ec-a405-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: George Dunlap , Dario Faggioli Subject: [PATCH 5/8] xen/sched: Remove unused-but-set variable Date: Wed, 27 Apr 2022 11:49:38 +0200 Message-Id: <20220427094941.291554-6-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220427094941.291554-1-michal.orzel@arm.com> References: <20220427094941.291554-1-michal.orzel@arm.com> MIME-Version: 1.0 Function schedule_cpu_add defines and sets a variable old_unit but does not make use of it. Remove this variable. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Dario Faggioli --- xen/common/sched/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab678181..8a8c25bbda 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3104,7 +3104,7 @@ int schedule_cpu_add(unsigned int cpu, struct cpupool *c) { const cpumask_t *mask; unsigned int cpu_iter, idx = 0; - struct sched_unit *old_unit, *master_unit; + struct sched_unit *master_unit; struct sched_resource *sr_old; /* @@ -3128,7 +3128,6 @@ int schedule_cpu_add(unsigned int cpu, struct cpupool *c) if ( cpu == cpu_iter ) continue; - old_unit = idle_vcpu[cpu_iter]->sched_unit; sr_old = get_sched_res(cpu_iter); kill_timer(&sr_old->s_timer); idle_vcpu[cpu_iter]->sched_unit = master_unit;