| Message ID | 20220427123316.329312-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | softmmu/vl: Fence 'xenfb' if Xen support is not compiled in | expand |
On Wed, Apr 27, 2022 at 02:33:16PM +0200, Thomas Huth wrote: > The 'xenfb' parameter for the '-vga' command line option is currently > always enabled unconditionally (since the xenfb is not a proper QOM > device that could be tested via its class name). That means it also > shows up if Xen is not enabled at all, e.g. like this: > > $ ./qemu-system-sparc -vga help > none no graphic card > xenfb Xen paravirtualized framebuffer > tcx TCX framebuffer (default) > cg3 CG3 framebuffer > > Let's avoid this situation by fencing the parameter with the > CONFIG_XEN_BACKEND switch. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Acked-by: Anthony PERARD <anthony.perard@citrix.com> Thanks,
diff --git a/softmmu/vl.c b/softmmu/vl.c index 06a0e342fe..e26421b815 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -934,10 +934,12 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = { .name = "CG3 framebuffer", .class_names = { "cgthree" }, }, +#ifdef CONFIG_XEN_BACKEND [VGA_XENFB] = { .opt_name = "xenfb", .name = "Xen paravirtualized framebuffer", }, +#endif }; static bool vga_interface_available(VGAInterfaceType t)
The 'xenfb' parameter for the '-vga' command line option is currently always enabled unconditionally (since the xenfb is not a proper QOM device that could be tested via its class name). That means it also shows up if Xen is not enabled at all, e.g. like this: $ ./qemu-system-sparc -vga help none no graphic card xenfb Xen paravirtualized framebuffer tcx TCX framebuffer (default) cg3 CG3 framebuffer Let's avoid this situation by fencing the parameter with the CONFIG_XEN_BACKEND switch. Signed-off-by: Thomas Huth <thuth@redhat.com> --- softmmu/vl.c | 2 ++ 1 file changed, 2 insertions(+)