| Message ID | 20220428095549.91409-1-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cirrus-ci: add myself as maintainer | expand |
On 28/04/2022 10:55, Roger Pau Monne wrote: > Given the testing done by Cirrus-CI is FreeBSD only introduce a new > section in the MAINTAINERS file to cover it and add myself as the > maintainer. > > Requested-by: Stefano Stabellini <sstabellini@kernel.org> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > FWIW, I wouldn't mind it being part of the "Continuous Integration > (CI)" section, but I understand maintainers there could prefer a > separate section since this is ATM FreeBSD only testing. I don't think we have enough review bandwidth to separate things like this. Plenty of changes to CI are dependency tweaks which cover all CI files in one go, so wouldn't be directly relevant to being FreeBSD. Also some CI changes need superpowers in other systems. I'd just add yourself to the general section. It's not as if you're an unknown person to the project... (and tbh, I should be in their too.) Tangentially, we should prune the final bits of Travis, and add .github/. ~Andrew
On Thu, 28 Apr 2022, Andrew Cooper wrote: > On 28/04/2022 10:55, Roger Pau Monne wrote: > > Given the testing done by Cirrus-CI is FreeBSD only introduce a new > > section in the MAINTAINERS file to cover it and add myself as the > > maintainer. > > > > Requested-by: Stefano Stabellini <sstabellini@kernel.org> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > FWIW, I wouldn't mind it being part of the "Continuous Integration > > (CI)" section, but I understand maintainers there could prefer a > > separate section since this is ATM FreeBSD only testing. > > I don't think we have enough review bandwidth to separate things like > this. Plenty of changes to CI are dependency tweaks which cover all CI > files in one go, so wouldn't be directly relevant to being FreeBSD. > Also some CI changes need superpowers in other systems. Today, gitlab-ci and cirrus-ci are entirely different systems: they don't share any containers or any other artifacts. So my preference is to have a separate entry in the MAINTAINERS file as Roger did in this patch. That would be more accurate in terms of roles, responsibilities and expectations. If someone sends a patch for .cirrus.yml, I definitely think Roger should be the one to have a look. My recommendation is to go ahead with this patch. We can always merge the sections in the future if the CI systems become more integrated. Acked-by: Stefano Stabellini <sstabellini@kernel.org>
diff --git a/MAINTAINERS b/MAINTAINERS index 2a47fafe85..6248d07aea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -260,6 +260,11 @@ R: Community Manager <community.manager@xenproject.org> S: Maintained F: CHANGELOG.md +Cirrus-CI Integration +M: Roger Pau Monné <roger.pau@citrix.com> +S: Supported +F: .cirrus.yml + Continuous Integration (CI) M: Doug Goldstein <cardoe@cardoe.com> M: Stefano Stabellini <sstabellini@kernel.org>
Given the testing done by Cirrus-CI is FreeBSD only introduce a new section in the MAINTAINERS file to cover it and add myself as the maintainer. Requested-by: Stefano Stabellini <sstabellini@kernel.org> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- FWIW, I wouldn't mind it being part of the "Continuous Integration (CI)" section, but I understand maintainers there could prefer a separate section since this is ATM FreeBSD only testing. --- MAINTAINERS | 5 +++++ 1 file changed, 5 insertions(+)