| Message ID | 20220614162248.40278-4-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: rework compat headers generation | expand |
On 14.06.2022 18:22, Anthony PERARD wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which python3 python python2 2>/dev/null) > export PYTHON ?= $(PYTHON_INTERPRETER) > > export CHECKPOLICY ?= checkpolicy > +export PERL ?= perl > > $(if $(filter __%, $(MAKECMDGOALS)), \ > $(error targets prefixed with '__' are only for internal use)) Considering my patch yesterday that moved the exporting of CC etc, I wonder if - at the very least for consistency - this and the neighbouring pre-existing exports shouldn't all be moved below the inclusion of ./Config.mk as well. After all ./config might override any of those. (Yes, the ones here don't prevent such overriding, but only as long as there aren't any further make quirks.) Since this may want doing in a separate patch, this one is Acked-by: Jan Beulich <jbeulich@suse.com> Jan
On Wed, Jun 15, 2022 at 08:11:10AM +0200, Jan Beulich wrote: > On 14.06.2022 18:22, Anthony PERARD wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which python3 python python2 2>/dev/null) > > export PYTHON ?= $(PYTHON_INTERPRETER) > > > > export CHECKPOLICY ?= checkpolicy > > +export PERL ?= perl > > > > $(if $(filter __%, $(MAKECMDGOALS)), \ > > $(error targets prefixed with '__' are only for internal use)) > > Considering my patch yesterday that moved the exporting of CC etc, I > wonder if - at the very least for consistency - this and the neighbouring > pre-existing exports shouldn't all be moved below the inclusion of > ./Config.mk as well. After all ./config might override any of those. > (Yes, the ones here don't prevent such overriding, but only as long as > there aren't any further make quirks.) Sounds good, we can move CHECKPOLICY and PERL, but there's a problem with PYTHON. Config.mk define a different value for PYTHON, so the one in xen/Makefile needs to be set before including ./Config.mk. Thanks,
diff --git a/xen/Makefile b/xen/Makefile index 82f5310b12..a6650a2acc 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -22,6 +22,7 @@ PYTHON_INTERPRETER := $(word 1,$(shell which python3 python python2 2>/dev/null) export PYTHON ?= $(PYTHON_INTERPRETER) export CHECKPOLICY ?= checkpolicy +export PERL ?= perl $(if $(filter __%, $(MAKECMDGOALS)), \ $(error targets prefixed with '__' are only for internal use)) diff --git a/README b/README index 5e55047ffd..c1c18de7e0 100644 --- a/README +++ b/README @@ -64,6 +64,7 @@ provided by your OS distributor: * iproute package (/sbin/ip) * GNU bison and GNU flex * ACPI ASL compiler (iasl) + * Perl In addition to the above there are a number of optional build prerequisites. Omitting these will cause the related features to be
We are going to use it in a moment. Also update README about Perl requirement. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: v2: - update ./README xen/Makefile | 1 + README | 1 + 2 files changed, 2 insertions(+)