| Message ID | 20220711105840.10533-1-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen/build: remove unneeded enumeration in clean-files | expand |
On Mon, Jul 11, 2022 at 12:58:40PM +0200, Juergen Gross wrote: > Enumerating a file from $(targets) in $(clean-files) isn't needed. > > Remove xen/include/xen/hypercall-defs.h from $(clean-files). > > Reported-by: Jan Beulich <jbeulich@suse.com> > Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > xen/include/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/Makefile b/xen/include/Makefile > index 39d9f5556c..fa0d454ab7 100644 > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -225,4 +225,4 @@ all: lib-x86-all > endif > > clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h > -clean-files += xen/hypercall-defs.h hypercall-defs.i > +clean-files += hypercall-defs.i The patch title is a bit too broad and only correct a recent patch. It doesn't really matter I think if `rm -f` tries to remove the same file twice, but maybe this patch should actually do what it is explained in the description ;-). There is also "headers*.chk" that is listed in both $(targets) and $(clean-files) which could be unlisted from the latter as well. Thanks,
diff --git a/xen/include/Makefile b/xen/include/Makefile index 39d9f5556c..fa0d454ab7 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -225,4 +225,4 @@ all: lib-x86-all endif clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h -clean-files += xen/hypercall-defs.h hypercall-defs.i +clean-files += hypercall-defs.i
Enumerating a file from $(targets) in $(clean-files) isn't needed. Remove xen/include/xen/hypercall-defs.h from $(clean-files). Reported-by: Jan Beulich <jbeulich@suse.com> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") Signed-off-by: Juergen Gross <jgross@suse.com> --- xen/include/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)