| Message ID | 20220816110340.35453-1-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] MAINTAINERS: CC Anthony on Xen's build system changes | expand |
On 16.08.2022 13:03, Anthony PERARD wrote: > I'd like to keep an eye on any changes in the Makefiles, to avoid > further break of the build system. > > With this entries, it means that THE REST will not be CCed anymore for > changes in > - xen/Makefile > - xen/*.mk > - xen/scripts/Kbuild.include > - xen/scripts/Makefile.* > This could be an issue. > > Most other files are also listed in other sections so would have a > maintainer. There's probably a few Makefiles in subdirectory that > would have CC THE REST but won't with this new section. Ideally the script would still pick REST if there's no M: entry; I have no idea whether that's already the case. > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -260,6 +260,20 @@ M: Rahul Singh <rahul.singh@arm.com> > S: Supported > F: xen/drivers/passthrough/arm/smmu-v3.c > > +BUILD SYSTEM XEN > +R: Anthony PERARD <anthony.perard@citrix.com> > +S: Supported > +F: xen/Makefile > +F: xen/*.mk > +F: xen/scripts/Kbuild.include > +F: xen/scripts/Makefile.* > +F: xen/common/efi/efi-common.mk > +F: xen/arch/*/*.mk > +F: xen/*/Makefile > +F: xen/*/*/Makefile > +F: xen/*/*/*/Makefile > +F: xen/*/*/*/*/Makefile I'm curious what the sorting criteria (if any) was for the individual F: lines. And I guess the last four lines can't really be collapsed into xen/**/Makefile ... Jan
diff --git a/MAINTAINERS b/MAINTAINERS index e12c499a28..088647ba11 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -260,6 +260,20 @@ M: Rahul Singh <rahul.singh@arm.com> S: Supported F: xen/drivers/passthrough/arm/smmu-v3.c +BUILD SYSTEM XEN +R: Anthony PERARD <anthony.perard@citrix.com> +S: Supported +F: xen/Makefile +F: xen/*.mk +F: xen/scripts/Kbuild.include +F: xen/scripts/Makefile.* +F: xen/common/efi/efi-common.mk +F: xen/arch/*/*.mk +F: xen/*/Makefile +F: xen/*/*/Makefile +F: xen/*/*/*/Makefile +F: xen/*/*/*/*/Makefile + Change Log M: Henry Wang <Henry.Wang@arm.com> R: Community Manager <community.manager@xenproject.org>
I'd like to keep an eye on any changes in the Makefiles, to avoid further break of the build system. With this entries, it means that THE REST will not be CCed anymore for changes in - xen/Makefile - xen/*.mk - xen/scripts/Kbuild.include - xen/scripts/Makefile.* This could be an issue. Most other files are also listed in other sections so would have a maintainer. There's probably a few Makefiles in subdirectory that would have CC THE REST but won't with this new section. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- I'm not sure if adding a maintainers would be needed, but maybe Jan? I could look at using lei from public-inbox, or just the search from public-inbox, but it's easier to tell people to CC me. Thanks. --- MAINTAINERS | 14 ++++++++++++++ 1 file changed, 14 insertions(+)