From patchwork Mon Nov 14 18:58:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13042702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08E8EC43217 for ; Mon, 14 Nov 2022 18:58:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.443517.698090 (Exim 4.92) (envelope-from ) id 1oueeu-0005Bs-Sb; Mon, 14 Nov 2022 18:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443517.698090; Mon, 14 Nov 2022 18:58:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueeu-0005AO-Lz; Mon, 14 Nov 2022 18:58:16 +0000 Received: by outflank-mailman (input) for mailman id 443517; Mon, 14 Nov 2022 18:58:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueet-0004ue-9K for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:58:15 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48400cd8-644e-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 19:58:12 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 10:58:07 -0800 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 14 Nov 2022 10:58:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E1657346; Mon, 14 Nov 2022 20:58:24 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48400cd8-644e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668452292; x=1699988292; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EaNuN468AX7oVVNzygbZKjeVdiuKUVO8jdpIxMpvwBE=; b=P5lylLczFWdt3wgH0tzVk+MLwe3rodaFgnK+V/FMEqBRctSACz5Z+hMQ vMeeybnRp7fFa9kKQnpu2Td7mN65RjEw48sqMWFaDyrm5+HcnFiJeUuyb wd4B4nh2gyI/TRAHmCvRQKDdJqHveplyKl5LrtBJzHKMjN/wNEAPnvaLe YHGX4HH0PLu9tasxsFzVy8nx/DslH8/oCpWxAnbO7IyD2Q2MjuDl02g0Z fdwCBcnDQw4Ln+Rv/5Ez/n27Fjy5JmL9qHsmU+fmYB+NrgeqXroxQydL8 z01dTrtwyAmt9NAW+f8tpCzHilISUY7llQW8a50QeO9LyNgk5oqi7z2+h Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295415990" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="295415990" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638607277" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638607277" From: Andy Shevchenko To: =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , Mika Westerberg , Andy Shevchenko , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , =?utf-8?q?Pali_Roh=C3=A1r?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Date: Mon, 14 Nov 2022 20:58:21 +0200 Message-Id: <20221114185822.65038-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> References: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c index 930c2332c3c4..907b86384396 100644 --- a/drivers/eisa/pci_eisa.c +++ b/drivers/eisa/pci_eisa.c @@ -20,8 +20,8 @@ static struct eisa_root_device pci_eisa_root; static int __init pci_eisa_init(struct pci_dev *pdev) { - int rc, i; struct resource *res, *bus_res = NULL; + int rc; if ((rc = pci_enable_device (pdev))) { dev_err(&pdev->dev, "Could not enable device\n"); @@ -38,7 +38,7 @@ static int __init pci_eisa_init(struct pci_dev *pdev) * eisa_root_register() can only deal with a single io port resource, * so we use the first valid io port resource. */ - pci_bus_for_each_resource(pdev->bus, res, i) + pci_bus_for_each_resource_p(pdev->bus, res) if (res && (res->flags & IORESOURCE_IO)) { bus_res = res; break;