| Message ID | 20221211175949.2193629-1-marmarek@invisiblethingslab.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | libxl: abort on memory allocation errors | expand |
On Sun, Dec 11, 2022 at 06:59:49PM +0100, Marek Marczykowski-Górecki wrote: > Use abort() instead of just _exit() in libxl__alloc_failed(). This > is more friendly for debugging, as it will trap into debugger, > systemd-coredump will collect coredump/backtrace etc. It's much more > useful than just "libxl: FATAL ERROR: memory allocation failure (...)" > message without context where it actually failed. > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> Acked-by: Anthony PERARD <anthony.perard@citrix.com> Thanks,
diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_internal.c index 86556b6113b0..c95624933ffc 100644 --- a/tools/libs/light/libxl_internal.c +++ b/tools/libs/light/libxl_internal.c @@ -36,7 +36,7 @@ void libxl__alloc_failed(libxl_ctx *ctx, const char *func, } fflush(stderr); - _exit(-1); + abort(); #undef M_NSIZE #undef M_SIZE #undef M
Use abort() instead of just _exit() in libxl__alloc_failed(). This is more friendly for debugging, as it will trap into debugger, systemd-coredump will collect coredump/backtrace etc. It's much more useful than just "libxl: FATAL ERROR: memory allocation failure (...)" message without context where it actually failed. Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> --- tools/libs/light/libxl_internal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)