From patchwork Tue Dec 20 08:50:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Fancellu X-Patchwork-Id: 13077646 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D90CC10F1E for ; Tue, 20 Dec 2022 08:51:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.466601.725590 (Exim 4.92) (envelope-from ) id 1p7YLO-0004Dh-PP; Tue, 20 Dec 2022 08:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 466601.725590; Tue, 20 Dec 2022 08:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p7YLO-0004D0-Iu; Tue, 20 Dec 2022 08:51:26 +0000 Received: by outflank-mailman (input) for mailman id 466601; Tue, 20 Dec 2022 08:51:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p7YLM-0001kP-U7 for xen-devel@lists.xenproject.org; Tue, 20 Dec 2022 08:51:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7b6174c3-8043-11ed-8fd4-01056ac49cbb; Tue, 20 Dec 2022 09:51:24 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73D4F13D5; Tue, 20 Dec 2022 00:52:04 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 687123F71A; Tue, 20 Dec 2022 00:51:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b6174c3-8043-11ed-8fd4-01056ac49cbb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 09/18] xen: cppcheck: misra rule 20.7 deviation on kconfig.h Date: Tue, 20 Dec 2022 08:50:51 +0000 Message-Id: <20221220085100.22848-10-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221220085100.22848-1-luca.fancellu@arm.com> References: <20221220085100.22848-1-luca.fancellu@arm.com> Cppcheck has found a violation of rule 20.7 for the macro __config_enabled but the preprocessor branch where this macro is defined should not be analysed by cppcheck when CPPCHECK macro is defined, hence this is a false positive of the tool and we can safely suppress the finding. Eclair and coverity does not report this finding. Signed-off-by: Luca Fancellu --- docs/misra/false-positive-cppcheck.json | 7 +++++++ xen/include/xen/kconfig.h | 1 + 2 files changed, 8 insertions(+) diff --git a/docs/misra/false-positive-cppcheck.json b/docs/misra/false-positive-cppcheck.json index 5e7d9377f60b..c8ee3c0c6317 100644 --- a/docs/misra/false-positive-cppcheck.json +++ b/docs/misra/false-positive-cppcheck.json @@ -17,6 +17,13 @@ }, { "id": "SAF-2-false-positive-cppcheck", + "violation-id": "misra-c2012-20.7", + "tool-version": "2.7", + "name": "R20.7 on preprocessor branch that should be disabled", + "text": "This preprocessor branch should be disabled when CPPCHECK macro is active, so there should not be violation." + }, + { + "id": "SAF-3-false-positive-cppcheck", "violation-id": "", "tool-version": "", "name": "Sentinel", diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h index a717b0819c2e..92373c018950 100644 --- a/xen/include/xen/kconfig.h +++ b/xen/include/xen/kconfig.h @@ -23,6 +23,7 @@ #define __ARG_PLACEHOLDER_1 0, #define config_enabled(cfg) _config_enabled(cfg) #define _config_enabled(value) __config_enabled(__ARG_PLACEHOLDER_##value) +/* SAF-2-false-positive-cppcheck R20.7 but cppcheck should not check here */ #define __config_enabled(arg1_or_junk) ___config_enabled(arg1_or_junk 1, 0) #define ___config_enabled(__ignored, val, ...) val