From patchwork Tue Dec 20 08:50:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Fancellu X-Patchwork-Id: 13077639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 272B2C4332F for ; Tue, 20 Dec 2022 08:51:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.466595.725526 (Exim 4.92) (envelope-from ) id 1p7YLI-0002XN-9R; Tue, 20 Dec 2022 08:51:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 466595.725526; Tue, 20 Dec 2022 08:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p7YLI-0002Wy-3p; Tue, 20 Dec 2022 08:51:20 +0000 Received: by outflank-mailman (input) for mailman id 466595; Tue, 20 Dec 2022 08:51:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p7YLF-0001kV-Vr for xen-devel@lists.xenproject.org; Tue, 20 Dec 2022 08:51:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 76c3abbb-8043-11ed-91b6-6bf2151ebd3b; Tue, 20 Dec 2022 09:51:16 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DE2113D5; Tue, 20 Dec 2022 00:51:57 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 595C53F71A; Tue, 20 Dec 2022 00:51:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76c3abbb-8043-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 03/18] arm: cppcheck: misra rule 20.7 deviation on asm_defns.h Date: Tue, 20 Dec 2022 08:50:45 +0000 Message-Id: <20221220085100.22848-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221220085100.22848-1-luca.fancellu@arm.com> References: <20221220085100.22848-1-luca.fancellu@arm.com> Cppcheck has found violations of rule 20.7 for the macros RODATA_STR() and ASM_INT(), but the macro parameters are never used as an expression, they are used for text subtitution and cppcheck is not taking into account the context of use for them, so we can suppress the finding. Eclair and coverity does not report these findings. Signed-off-by: Luca Fancellu --- xen/arch/arm/include/asm/asm_defns.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/include/asm/asm_defns.h b/xen/arch/arm/include/asm/asm_defns.h index 29a9dbb002fa..9bf4cf8891f5 100644 --- a/xen/arch/arm/include/asm/asm_defns.h +++ b/xen/arch/arm/include/asm/asm_defns.h @@ -22,11 +22,13 @@ # error "unknown ARM variant" #endif +/* SAF-1-false-positive-cppcheck R20.7 argument as text substitution */ #define RODATA_STR(label, msg) \ .pushsection .rodata.str, "aMS", %progbits, 1 ; \ label: .asciz msg; \ .popsection +/* SAF-1-false-positive-cppcheck R20.7 argument as text substitution */ #define ASM_INT(label, val) \ .p2align 2; \ label: .long (val); \