| Message ID | 20230103200943.5801-2-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix truncation of various XENVER_* subops | expand |
Hi Andrew, On 03/01/2023 20:09, Andrew Cooper wrote: > This is technically an ABI change, but Xen doesn't operate in any environment > where "unsigned int" is differnet to uint32_t, so switch to the explicit form. typo: s/differnet/different/ > This avoids the need to derive (identical) compat logic for handling the > subop. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Julien Grall <jgrall@amazon.com> Cheers, > --- > CC: George Dunlap <George.Dunlap@eu.citrix.com> > CC: Jan Beulich <JBeulich@suse.com> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Wei Liu <wl@xen.org> > CC: Julien Grall <julien@xen.org> > --- > xen/include/public/version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/public/version.h b/xen/include/public/version.h > index 9c78b4f3b6a4..0ff8bd9077c6 100644 > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -50,7 +50,7 @@ typedef struct xen_platform_parameters xen_platform_parameters_t; > > #define XENVER_get_features 6 > struct xen_feature_info { > - unsigned int submap_idx; /* IN: which 32-bit submap to return */ > + uint32_t submap_idx; /* IN: which 32-bit submap to return */ > uint32_t submap; /* OUT: 32-bit submap */ > }; > typedef struct xen_feature_info xen_feature_info_t;
diff --git a/xen/include/public/version.h b/xen/include/public/version.h index 9c78b4f3b6a4..0ff8bd9077c6 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -50,7 +50,7 @@ typedef struct xen_platform_parameters xen_platform_parameters_t; #define XENVER_get_features 6 struct xen_feature_info { - unsigned int submap_idx; /* IN: which 32-bit submap to return */ + uint32_t submap_idx; /* IN: which 32-bit submap to return */ uint32_t submap; /* OUT: 32-bit submap */ }; typedef struct xen_feature_info xen_feature_info_t;
This is technically an ABI change, but Xen doesn't operate in any environment where "unsigned int" is differnet to uint32_t, so switch to the explicit form. This avoids the need to derive (identical) compat logic for handling the subop. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: George Dunlap <George.Dunlap@eu.citrix.com> CC: Jan Beulich <JBeulich@suse.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Wei Liu <wl@xen.org> CC: Julien Grall <julien@xen.org> --- xen/include/public/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)