From patchwork Sat Jan 28 00:37:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Srivatsa S. Bhat" X-Patchwork-Id: 13119590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0081DC38142 for ; Sat, 28 Jan 2023 00:39:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.486017.753482 (Exim 4.92) (envelope-from ) id 1pLZF6-0004tO-7v; Sat, 28 Jan 2023 00:38:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 486017.753482; Sat, 28 Jan 2023 00:38:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pLZF6-0004tH-56; Sat, 28 Jan 2023 00:38:52 +0000 Received: by outflank-mailman (input) for mailman id 486017; Sat, 28 Jan 2023 00:38:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pLZF5-0004sT-Ns for xen-devel@lists.xenproject.org; Sat, 28 Jan 2023 00:38:51 +0000 Received: from outgoing2021.csail.mit.edu (outgoing2021.csail.mit.edu [128.30.2.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1faad50f-9ea4-11ed-b8d1-410ff93cb8f0; Sat, 28 Jan 2023 01:38:47 +0100 (CET) Received: from [64.186.27.43] (helo=srivatsa-dev.eng.vmware.com) by outgoing2021.csail.mit.edu with esmtpa (Exim 4.95) (envelope-from ) id 1pLZER-000elb-VP; Fri, 27 Jan 2023 19:38:12 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1faad50f-9ea4-11ed-b8d1-410ff93cb8f0 From: "Srivatsa S. Bhat" To: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, peterz@infradead.org, hpa@zytor.com Cc: bp@alien8.de, dave.hansen@linux.intel.com, rafael.j.wysocki@intel.com, paulmck@kernel.org, jgross@suse.com, seanjc@google.com, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org, imammedo@redhat.com, amakhalov@vmware.com, ganb@vmware.com, ankitja@vmware.com, bordoloih@vmware.com, keerthanak@vmware.com, blamoreaux@vmware.com, namit@vmware.com, wyes.karny@amd.com, lewis.carroll@amd.com, pv-drivers@vmware.com, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, srivatsa@csail.mit.edu Subject: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() Date: Fri, 27 Jan 2023 16:37:51 -0800 Message-Id: <20230128003751.141317-1-srivatsa@csail.mit.edu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 From: "Srivatsa S. Bhat (VMware)" The comment that says mwait_play_dead() returns only on failure is a bit misleading because mwait_play_dead() could actually return for valid reasons (such as mwait not being supported by the platform) that do not indicate a failure of the CPU offline operation. So, remove the comment. Suggested-by: Thomas Gleixner Signed-off-by: Srivatsa S. Bhat (VMware) --- arch/x86/kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 55cad72715d9..9013bb28255a 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1833,7 +1833,7 @@ void native_play_dead(void) play_dead_common(); tboot_shutdown(TB_SHUTDOWN_WFS); - mwait_play_dead(); /* Only returns on failure */ + mwait_play_dead(); if (cpuidle_play_dead()) hlt_play_dead(); }