| Message ID | 20230221165542.7642-7-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | automation: Update containers to allow HTTPS access to xenbits | expand |
On 21/02/2023 4:55 pm, Anthony PERARD wrote: > Jessie as rearch EOL in 2020. > > Even if we update the containers, we would still not be able to reach > HTTPS webside with Let's Encrypt certificates and thus would need more > change to the container. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> How is this interact with the other patches in the series? I presume we do want to take patch 4 and rebuild the containers, for the older branches. And that's fine. And IMO we should be dropping jessie testing, so this is almost fine for staging. Except, jessie-32 is the only x86-32 build test we've got, so I think we want to replace it with a newer container before dropping the jessie*. > --- > Notes: > HTTPS would fail unless we commit "automation: Remove expired root > certificates used to be used by let's encrypt", that is. Patch still in > the series, and fix Jessie. If we're dropping the jessie containers, do we really need that change too? Because we really shouldn't be playing around with URLs on older branches. ~Andrew
On 21/02/2023 5:59 pm, Andrew Cooper wrote: > On 21/02/2023 4:55 pm, Anthony PERARD wrote: >> Jessie as rearch EOL in 2020. >> >> Even if we update the containers, we would still not be able to reach >> HTTPS webside with Let's Encrypt certificates and thus would need more >> change to the container. >> >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > How is this interact with the other patches in the series? > > I presume we do want to take patch 4 and rebuild the containers, for the > older branches. And that's fine. > > And IMO we should be dropping jessie testing, so this is almost fine for > staging. > > Except, jessie-32 is the only x86-32 build test we've got, so I think we > want to replace it with a newer container before dropping the jessie*. Further to this, I really don't think we need to have a 4-wide matrix of {clang,gcc}{debug,release} for just a 32bit tools userspace. Debug clang+gcc will do, and save on some testing cycles. ~Andrew > >> --- >> Notes: >> HTTPS would fail unless we commit "automation: Remove expired root >> certificates used to be used by let's encrypt", that is. Patch still in >> the series, and fix Jessie. > If we're dropping the jessie containers, do we really need that change > too? Because we really shouldn't be playing around with URLs on older > branches. > > ~Andrew
On Tue, Feb 21, 2023 at 06:01:19PM +0000, Andrew Cooper wrote: > On 21/02/2023 5:59 pm, Andrew Cooper wrote: > > On 21/02/2023 4:55 pm, Anthony PERARD wrote: > >> Jessie as rearch EOL in 2020. > >> > >> Even if we update the containers, we would still not be able to reach > >> HTTPS webside with Let's Encrypt certificates and thus would need more > >> change to the container. > >> > >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > > How is this interact with the other patches in the series? > > > > I presume we do want to take patch 4 and rebuild the containers, for the > > older branches. And that's fine. > > > > And IMO we should be dropping jessie testing, so this is almost fine for > > staging. > > > > Except, jessie-32 is the only x86-32 build test we've got, so I think we > > want to replace it with a newer container before dropping the jessie*. Actually, we have two mores: debian-unstable-32-* and debian-stretch-32-*. So an old distrib and a very new. So there's probably no need to add more. > Further to this, I really don't think we need to have a 4-wide matrix of > {clang,gcc}{debug,release} for just a 32bit tools userspace. Debug > clang+gcc will do, and save on some testing cycles. I guess we could remove debian-{stretch,unstable}-32-{clang,gcc}. I'll add a patch for that. > ~Andrew > > > > >> --- > >> Notes: > >> HTTPS would fail unless we commit "automation: Remove expired root > >> certificates used to be used by let's encrypt", that is. Patch still in > >> the series, and fix Jessie. > > If we're dropping the jessie containers, do we really need that change > > too? Because we really shouldn't be playing around with URLs on older > > branches. No, there's no need to change it. It's just a bit confusing to both update and delete. In the patch that remove the debian-jessie jobs, I kind of want to also remove the dockerfile, but if the dockerfile is updated in the series it is weird to remove it in that same series. Thanks,
diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 22ce1c45e7..2be1b05d5c 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -221,46 +221,6 @@ centos-7-gcc-debug: variables: CONTAINER: centos:7 -debian-jessie-clang: - extends: .clang-x86-64-build - variables: - CONTAINER: debian:jessie - -debian-jessie-clang-debug: - extends: .clang-x86-64-build-debug - variables: - CONTAINER: debian:jessie - -debian-jessie-gcc: - extends: .gcc-x86-64-build - variables: - CONTAINER: debian:jessie - -debian-jessie-gcc-debug: - extends: .gcc-x86-64-build-debug - variables: - CONTAINER: debian:jessie - -debian-jessie-32-clang: - extends: .clang-x86-32-build - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-clang-debug: - extends: .clang-x86-32-build-debug - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-gcc: - extends: .gcc-x86-32-build - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-gcc-debug: - extends: .gcc-x86-32-build-debug - variables: - CONTAINER: debian:jessie-i386 - debian-stretch-clang: extends: .clang-x86-64-build variables:
Jessie as rearch EOL in 2020. Even if we update the containers, we would still not be able to reach HTTPS webside with Let's Encrypt certificates and thus would need more change to the container. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: HTTPS would fail unless we commit "automation: Remove expired root certificates used to be used by let's encrypt", that is. Patch still in the series, and fix Jessie. automation/gitlab-ci/build.yaml | 40 --------------------------------- 1 file changed, 40 deletions(-)