| Message ID | 20230721121627.1229906-1-luca.fancellu@arm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [OSSTEST] ts-kernel-build: add kernel kconfig for the Arndale | expand |
On Fri, Jul 21, 2023 at 01:16:27PM +0100, Luca Fancellu wrote: > The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has > removed the 'snps,dwc-ahci' compatible from the generic > AHCI-platform driver control module selected by > CONFIG_SATA_AHCI_PLATFORM. > > A new driver, the DWC AHCI SATA platform driver is now implemented > and handles the above compatible when CONFIG_AHCI_DWC is selected. > > The module is needed for the Arndale board to have the SATA controller > working, so enable the CONFIG_AHCI_DWC as additional kconfig parameter > in ts-kernel-build. > > Signed-off-by: Luca Fancellu <luca.fancellu@arm.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> > --- > Tested successfully on: > - arndale-lakeside > - arndale-metrocentre > - arndale-westfield > > arndale-bluewater must have some HW issue, don't have much more info ATM. > --- > ts-kernel-build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ts-kernel-build b/ts-kernel-build > index 6c8f1d6a..73104874 100755 > --- a/ts-kernel-build > +++ b/ts-kernel-build > @@ -245,6 +245,7 @@ setopt CONFIG_SENSORS_LM90 n > setopt CONFIG_ICS932S401 n > > # Enable some additional drivers for Arndale. > +setopt CONFIG_AHCI_DWC y I would have added at the bottom of the Arndale list, but it's easier for context to see it belongs in the Arndale section. Thanks, Roger.
On 21.07.2023 14:16, Luca Fancellu wrote: > The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has > removed the 'snps,dwc-ahci' compatible from the generic > AHCI-platform driver control module selected by > CONFIG_SATA_AHCI_PLATFORM. > > A new driver, the DWC AHCI SATA platform driver is now implemented > and handles the above compatible when CONFIG_AHCI_DWC is selected. > > The module is needed for the Arndale board to have the SATA controller > working, so enable the CONFIG_AHCI_DWC as additional kconfig parameter > in ts-kernel-build. Largely out of curiosity: Since you say "module" here, ... > --- a/ts-kernel-build > +++ b/ts-kernel-build > @@ -245,6 +245,7 @@ setopt CONFIG_SENSORS_LM90 n > setopt CONFIG_ICS932S401 n > > # Enable some additional drivers for Arndale. > +setopt CONFIG_AHCI_DWC y ... does it really need to be y (and not m) here? Jan
> On 21 Jul 2023, at 14:24, Jan Beulich <jbeulich@suse.com> wrote: > > On 21.07.2023 14:16, Luca Fancellu wrote: >> The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has >> removed the 'snps,dwc-ahci' compatible from the generic >> AHCI-platform driver control module selected by >> CONFIG_SATA_AHCI_PLATFORM. >> >> A new driver, the DWC AHCI SATA platform driver is now implemented >> and handles the above compatible when CONFIG_AHCI_DWC is selected. >> >> The module is needed for the Arndale board to have the SATA controller >> working, so enable the CONFIG_AHCI_DWC as additional kconfig parameter >> in ts-kernel-build. Hi Jan, > > Largely out of curiosity: Since you say "module" here, ... > >> --- a/ts-kernel-build >> +++ b/ts-kernel-build >> @@ -245,6 +245,7 @@ setopt CONFIG_SENSORS_LM90 n >> setopt CONFIG_ICS932S401 n >> >> # Enable some additional drivers for Arndale. >> +setopt CONFIG_AHCI_DWC y > > ... does it really need to be y (and not m) here? I didn’t try with m before because I was unsure where the kernel module were put (in the disk? But then we need to read it), but now I did a try with ‘m’ and it works, so I guess the module are put in some ramdisk instead of the disk we want to read. Thanks for pointing that out. @Roger, is it possible to change it on commit or should I send a v2? Cheers, Luca > > Jan
On Fri, Jul 21, 2023 at 04:45:44PM +0000, Luca Fancellu wrote: > > On 21 Jul 2023, at 14:24, Jan Beulich <jbeulich@suse.com> wrote: > > On 21.07.2023 14:16, Luca Fancellu wrote: > >> --- a/ts-kernel-build > >> +++ b/ts-kernel-build > >> @@ -245,6 +245,7 @@ setopt CONFIG_SENSORS_LM90 n > >> setopt CONFIG_ICS932S401 n > >> > >> # Enable some additional drivers for Arndale. > >> +setopt CONFIG_AHCI_DWC y > > > > ... does it really need to be y (and not m) here? > > I didn’t try with m before because I was unsure where the kernel module were put (in the disk? But then we need to read it), > but now I did a try with ‘m’ and it works, so I guess the module are put in some ramdisk instead of the disk we want to read. > > Thanks for pointing that out. > > @Roger, is it possible to change it on commit or should I send a v2? I've pushed the patch to "pretest" with this modification. If osstest is happy with the patch (that is no regression with a "xen-unstable" flight), it will be committed. Thanks,
> On 24 Jul 2023, at 11:28, Anthony PERARD <anthony.perard@citrix.com> wrote: > > On Fri, Jul 21, 2023 at 04:45:44PM +0000, Luca Fancellu wrote: >>> On 21 Jul 2023, at 14:24, Jan Beulich <jbeulich@suse.com> wrote: >>> On 21.07.2023 14:16, Luca Fancellu wrote: >>>> --- a/ts-kernel-build >>>> +++ b/ts-kernel-build >>>> @@ -245,6 +245,7 @@ setopt CONFIG_SENSORS_LM90 n >>>> setopt CONFIG_ICS932S401 n >>>> >>>> # Enable some additional drivers for Arndale. >>>> +setopt CONFIG_AHCI_DWC y >>> >>> ... does it really need to be y (and not m) here? >> >> I didn’t try with m before because I was unsure where the kernel module were put (in the disk? But then we need to read it), >> but now I did a try with ‘m’ and it works, so I guess the module are put in some ramdisk instead of the disk we want to read. >> >> Thanks for pointing that out. >> >> @Roger, is it possible to change it on commit or should I send a v2? > > I've pushed the patch to "pretest" with this modification. Thanks Anthony > > If osstest is happy with the patch (that is no regression with a > "xen-unstable" flight), it will be committed. Fingers crossed Cheers, Luca > > Thanks, > > -- > Anthony PERARD
diff --git a/ts-kernel-build b/ts-kernel-build index 6c8f1d6a..73104874 100755 --- a/ts-kernel-build +++ b/ts-kernel-build @@ -245,6 +245,7 @@ setopt CONFIG_SENSORS_LM90 n setopt CONFIG_ICS932S401 n # Enable some additional drivers for Arndale. +setopt CONFIG_AHCI_DWC y setopt CONFIG_PHY_EXYNOS5250_SATA m setopt CONFIG_USB_EHCI_EXYNOS m setopt CONFIG_USB_OHCI_EXYNOS m
The Linux commit 33629d35090f5ce2b1b4ce78aa39954c603536d5 has removed the 'snps,dwc-ahci' compatible from the generic AHCI-platform driver control module selected by CONFIG_SATA_AHCI_PLATFORM. A new driver, the DWC AHCI SATA platform driver is now implemented and handles the above compatible when CONFIG_AHCI_DWC is selected. The module is needed for the Arndale board to have the SATA controller working, so enable the CONFIG_AHCI_DWC as additional kconfig parameter in ts-kernel-build. Signed-off-by: Luca Fancellu <luca.fancellu@arm.com> --- Tested successfully on: - arndale-lakeside - arndale-metrocentre - arndale-westfield arndale-bluewater must have some HW issue, don't have much more info ATM. --- ts-kernel-build | 1 + 1 file changed, 1 insertion(+)