diff mbox series

[v4,13/13] xen/arm: mmu: enable SMMU subsystem only in MMU

Message ID 20230801034419.2047541-14-Henry.Wang@arm.com (mailing list archive)
State Superseded
Headers show
Series xen/arm: Split MMU code as the prepration of MPU work | expand

Commit Message

Henry Wang Aug. 1, 2023, 3:44 a.m. UTC 
From: Penny Zheng <Penny.Zheng@arm.com>

SMMU subsystem is only supported in MMU system, so we make it dependent
on CONFIG_HAS_MMU.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Signed-off-by: Wei Chen <wei.chen@arm.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
v4:
- No change
v3:
- new patch
---
 xen/drivers/passthrough/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jan Beulich Aug. 1, 2023, 7:43 a.m. UTC | #1 
On 01.08.2023 05:44, Henry Wang wrote:
> From: Penny Zheng <Penny.Zheng@arm.com>
> 
> SMMU subsystem is only supported in MMU system, so we make it dependent
> on CONFIG_HAS_MMU.
> 
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Signed-off-by: Wei Chen <wei.chen@arm.com>
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>

While entirely Arm-specific, this looks to require a non-Arm ack:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
Henry Wang Aug. 1, 2023, 7:47 a.m. UTC | #2 
(+ Julien, Stefano, Bertrand)

Hi Jan,

> -----Original Message-----
> Subject: Re: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only
> in MMU
> 
> On 01.08.2023 05:44, Henry Wang wrote:
> > From: Penny Zheng <Penny.Zheng@arm.com>
> >
> > SMMU subsystem is only supported in MMU system, so we make it
> dependent
> > on CONFIG_HAS_MMU.
> >
> > Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> > Signed-off-by: Wei Chen <wei.chen@arm.com>
> > Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> 
> While entirely Arm-specific, this looks to require a non-Arm ack:

Exactly, the default "Cc:" list was from the add_maintainers.pl and
I noticed this right after sending the patch out. I will add the Arm
maintainers in this reply (sorry for the inconvenience caused).

> Acked-by: Jan Beulich <jbeulich@suse.com>

Thank you very much!

Kind regards,
Henry

> 
> Jan
Henry Wang Aug. 10, 2023, 8:07 a.m. UTC | #3 
Hi Jan,

> On Aug 1, 2023, at 15:43, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 01.08.2023 05:44, Henry Wang wrote:
>> From: Penny Zheng <Penny.Zheng@arm.com>
>> 
>> SMMU subsystem is only supported in MMU system, so we make it dependent
>> on CONFIG_HAS_MMU.
>> 
>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>> Signed-off-by: Wei Chen <wei.chen@arm.com>
>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> 
> While entirely Arm-specific, this looks to require a non-Arm ack:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Based on the discussion in [1], now CONFIG_HAS_MMU is agreed to be renamed
as CONFIG_MMU, I will do the renaming but I would like to confirm with you that
if I can still take your asked-by tag with such change. Thanks!

[1] https://lore.kernel.org/xen-devel/429625da-ec4f-448f-a0c4-47ca0f62f395@xen.org/

Kind regards,
Henry

> 
> Jan
Jan Beulich Aug. 10, 2023, 8:11 a.m. UTC | #4 
On 10.08.2023 10:07, Henry Wang wrote:
>> On Aug 1, 2023, at 15:43, Jan Beulich <jbeulich@suse.com> wrote:
>> On 01.08.2023 05:44, Henry Wang wrote:
>>> From: Penny Zheng <Penny.Zheng@arm.com>
>>>
>>> SMMU subsystem is only supported in MMU system, so we make it dependent
>>> on CONFIG_HAS_MMU.
>>>
>>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>>> Signed-off-by: Wei Chen <wei.chen@arm.com>
>>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>>
>> While entirely Arm-specific, this looks to require a non-Arm ack:
>> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Based on the discussion in [1], now CONFIG_HAS_MMU is agreed to be renamed
> as CONFIG_MMU, I will do the renaming but I would like to confirm with you that
> if I can still take your asked-by tag with such change. Thanks!

Yes, that's fine to retain.

Jan
diff mbox series

Patch

diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
index 864fcf3b0c..5a8d666829 100644
--- a/xen/drivers/passthrough/Kconfig
+++ b/xen/drivers/passthrough/Kconfig
@@ -5,6 +5,7 @@  config HAS_PASSTHROUGH
 if ARM
 config ARM_SMMU
 	bool "ARM SMMUv1 and v2 driver"
+	depends on HAS_MMU
 	default y
 	---help---
 	  Support for implementations of the ARM System MMU architecture
@@ -15,7 +16,7 @@  config ARM_SMMU
 
 config ARM_SMMU_V3
 	bool "ARM Ltd. System MMU Version 3 (SMMUv3) Support" if EXPERT
-	depends on ARM_64 && (!ACPI || BROKEN)
+	depends on ARM_64 && (!ACPI || BROKEN) && HAS_MMU
 	---help---
 	 Support for implementations of the ARM System MMU architecture
 	 version 3. Driver is in experimental stage and should not be used in