| Message ID | 20230819002850.32349-5-vikram.garhwal@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dynamic node programming using overlay dtbo | expand |
Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: > Following changes are done to __unflatten_device_tree(): > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > 2. Remove __init and static function type. > > The changes are done to make this function useable for dynamic node programming > where new device tree overlay nodes are added to fdt and further unflattend to > update xen device tree during runtime. > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> It is not clear to me whether you saw my reply about using ERR_PTR() as I can't find an answer. Anyway, I am not against this interface: Acked-by: Julien Grall <jgrall@amazon.com> Cheers,
Hi Julien, On Tue, Aug 22, 2023 at 08:05:18PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Following changes are done to __unflatten_device_tree(): > > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > > 2. Remove __init and static function type. > > > > The changes are done to make this function useable for dynamic node programming > > where new device tree overlay nodes are added to fdt and further unflattend to > > update xen device tree during runtime. > > > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> > > It is not clear to me whether you saw my reply about using ERR_PTR() as I > can't find an answer. > I saw the comment but was not able to work on implementing ERR_PRT(). Given that I see your Acked-by, i will try to address this as separate patch after this series. > Anyway, I am not against this interface: > > Acked-by: Julien Grall <jgrall@amazon.com> > > Cheers, > > -- > Julien Grall
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index d70b6a7ac9..67e9b6de3e 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -2082,18 +2082,7 @@ static unsigned long unflatten_dt_node(const void *fdt, return mem; } -/** - * __unflatten_device_tree - create tree of device_nodes from flat blob - * - * unflattens a device-tree, creating the - * tree of struct device_node. It also fills the "name" and "type" - * pointers of the nodes so the normal device-tree walking functions - * can be used. - * @fdt: The fdt to expand - * @mynodes: The device_node tree created by the call - */ -static int __init __unflatten_device_tree(const void *fdt, - struct dt_device_node **mynodes) +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) { unsigned long start, mem, size; struct dt_device_node **allnextp = mynodes; @@ -2232,10 +2221,10 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) void __init dt_unflatten_host_device_tree(void) { - int error = __unflatten_device_tree(device_tree_flattened, &dt_host); + int error = unflatten_device_tree(device_tree_flattened, &dt_host); if ( error ) - panic("__unflatten_device_tree failed with error %d\n", error); + panic("unflatten_device_tree failed with error %d\n", error); dt_alias_scan(); } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 1d79e23b28..5941599eff 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -178,6 +178,18 @@ int device_tree_for_each_node(const void *fdt, int node, */ void dt_unflatten_host_device_tree(void); +/** + * unflatten_device_tree - create tree of device_nodes from flat blob + * + * unflattens a device-tree, creating the + * tree of struct device_node. It also fills the "name" and "type" + * pointers of the nodes so the normal device-tree walking functions + * can be used. + * @fdt: The fdt to expand + * @mynodes: The device_node tree created by the call + */ +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes); + /** * IRQ translation callback * TODO: For the moment we assume that we only have ONE
Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static function type. The changes are done to make this function useable for dynamic node programming where new device tree overlay nodes are added to fdt and further unflattend to update xen device tree during runtime. Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> --- Changes from v7: Update the commit with why unflatten_device_tree() is changed. Move function documentation to device_tree.h --- --- xen/common/device_tree.c | 17 +++-------------- xen/include/xen/device_tree.h | 12 ++++++++++++ 2 files changed, 15 insertions(+), 14 deletions(-)