Message ID | 20230830155326.10199-2-alejandro.vallejo@cloud.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Prevent attempting updates known to fail | expand |
On 30.08.2023 17:53, Alejandro Vallejo wrote: > Currently there's a printk statement triggered when no ucode loading > facilities are discovered. This statement should have severity INFO rather > than WARNING because it's not reporting anything wrong. Warnings ought > to be reserved for recoverable system errors. > > Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 9fcb9c1c3a..e5e03cad34 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -863,7 +863,7 @@ int __init early_microcode_init(unsigned long *module_map, if ( !ucode_ops.apply_microcode ) { - printk(XENLOG_WARNING "Microcode loading not available\n"); + printk(XENLOG_INFO "Microcode loading not available\n"); return -ENODEV; }
Currently there's a printk statement triggered when no ucode loading facilities are discovered. This statement should have severity INFO rather than WARNING because it's not reporting anything wrong. Warnings ought to be reserved for recoverable system errors. Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com> -- v8: * New patch to unify the severity of this printk statement with the statement introduced in patch 2 --- xen/arch/x86/cpu/microcode/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)