| Message ID | 20230927140133.631192-3-luca.fancellu@arm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fine granular configuration | expand |
Hi Luca, On 27/09/2023 15:01, Luca Fancellu wrote: > The 'enum domain_type' is defined by 'asm/domain.h' which is not > included (directly or indirectly) by 'asm/kernel.h'. > > This currently doesn't break the compilation because asm/domain.h will > included by the user of 'kernel.h'. But it would be better to avoid > relying on it. So add the include in 'asm/domain.h'. > > Signed-off-by: Luca Fancellu <luca.fancellu@arm.com> Acked-by: Julien Grall <jgrall@amazon.com> Cheers,
diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 4617cdc83bac..0a23e86c2d37 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -7,6 +7,7 @@ #define __ARCH_ARM_KERNEL_H__ #include <xen/device_tree.h> +#include <asm/domain.h> #include <asm/setup.h> /*
The 'enum domain_type' is defined by 'asm/domain.h' which is not included (directly or indirectly) by 'asm/kernel.h'. This currently doesn't break the compilation because asm/domain.h will included by the user of 'kernel.h'. But it would be better to avoid relying on it. So add the include in 'asm/domain.h'. Signed-off-by: Luca Fancellu <luca.fancellu@arm.com> --- Changes from v1: - Rephrased commit message (Julien) --- xen/arch/arm/include/asm/kernel.h | 1 + 1 file changed, 1 insertion(+)