| Message ID | 20230928114835.2592187-1-ayan.kumar.halder@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [XEN,v1] xen: arm: procinfo.h: Fixed a typo | expand |
Hi Ayan, On 28/09/2023 12:48, Ayan Kumar Halder wrote: > Change VPCU to VCPU. > > Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com> > --- > xen/arch/arm/include/asm/procinfo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/include/asm/procinfo.h b/xen/arch/arm/include/asm/procinfo.h > index 02be56e348..8b8dae3dd4 100644 > --- a/xen/arch/arm/include/asm/procinfo.h > +++ b/xen/arch/arm/include/asm/procinfo.h > @@ -24,7 +24,7 @@ > #include <xen/sched.h> > > struct processor { > - /* Initialize specific processor register for the new VPCU*/ > + /* Initialize specific processor register for the new VCPU*/ As you are modifying the line, can you also add the missing space before */? I have also a slight preference for using vCPU over VCPU. With that addressed: Acked-by: Julien Grall <jgrall@amazon.com> Cheers,
On 28/09/2023 12:57, Julien Grall wrote: > > Hi Ayan, Hi Julien, > > On 28/09/2023 12:48, Ayan Kumar Halder wrote: >> Change VPCU to VCPU. >> >> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com> >> --- >> xen/arch/arm/include/asm/procinfo.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/include/asm/procinfo.h >> b/xen/arch/arm/include/asm/procinfo.h >> index 02be56e348..8b8dae3dd4 100644 >> --- a/xen/arch/arm/include/asm/procinfo.h >> +++ b/xen/arch/arm/include/asm/procinfo.h >> @@ -24,7 +24,7 @@ >> #include <xen/sched.h> >> struct processor { >> - /* Initialize specific processor register for the new VPCU*/ >> + /* Initialize specific processor register for the new VCPU*/ > > As you are modifying the line, can you also add the missing space > before */? > > I have also a slight preference for using vCPU over VCPU. I will address both of your suggestions and send a v2. Just fyi, I see vCPU and VCPU used interchangebly. xen/arch/arm/include/asm/new_vgic.h uses VCPU. xen/arch/arm/vgic-v2.c uses vCPU. > > With that addressed: > > Acked-by: Julien Grall <jgrall@amazon.com> > > Cheers, - Ayan
diff --git a/xen/arch/arm/include/asm/procinfo.h b/xen/arch/arm/include/asm/procinfo.h index 02be56e348..8b8dae3dd4 100644 --- a/xen/arch/arm/include/asm/procinfo.h +++ b/xen/arch/arm/include/asm/procinfo.h @@ -24,7 +24,7 @@ #include <xen/sched.h> struct processor { - /* Initialize specific processor register for the new VPCU*/ + /* Initialize specific processor register for the new VCPU*/ void (*vcpu_initialise)(struct vcpu *v); };
Change VPCU to VCPU. Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com> --- xen/arch/arm/include/asm/procinfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)