| Message ID | 20231006135745.1038947-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for-4.18] x86/memshr: Fix build in copy_vcpu_settings() | expand |
Hi Andrew, > On Oct 6, 2023, at 21:57, Andrew Cooper <andrew.cooper3@citrix.com> wrote: > > The last user of this variable was dropped. > > Fixes: 295514ff7550 ("common: convert vCPU info area registration") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Release-acked-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry > --- > CC: Jan Beulich <JBeulich@suse.com> > CC: Roger Pau Monné <roger.pau@citrix.com> > CC: Wei Liu <wl@xen.org> > CC: Tamas K Lengyel <tamas@tklengyel.com> > CC: Henry Wang <Henry.Wang@arm.com> > > I expect Gitlab randconfig to find this eventually, but it does depend on > CONFIG_MEM_SHARING being active to manifest. > --- > xen/arch/x86/mm/mem_sharing.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > index 5217c755a299..94b6b782ef2e 100644 > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -1706,7 +1706,6 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d) > { > unsigned int i; > int ret = -EINVAL; > - mfn_t vcpu_info_mfn; > > for ( i = 0; i < cd->max_vcpus; i++ ) > { > -- > 2.30.2 >
On Fri, Oct 06, 2023 at 02:57:45PM +0100, Andrew Cooper wrote: > The last user of this variable was dropped. > > Fixes: 295514ff7550 ("common: convert vCPU info area registration") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Thanks for noticing this.
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 5217c755a299..94b6b782ef2e 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1706,7 +1706,6 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d) { unsigned int i; int ret = -EINVAL; - mfn_t vcpu_info_mfn; for ( i = 0; i < cd->max_vcpus; i++ ) {
The last user of this variable was dropped. Fixes: 295514ff7550 ("common: convert vCPU info area registration") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Wei Liu <wl@xen.org> CC: Tamas K Lengyel <tamas@tklengyel.com> CC: Henry Wang <Henry.Wang@arm.com> I expect Gitlab randconfig to find this eventually, but it does depend on CONFIG_MEM_SHARING being active to manifest. --- xen/arch/x86/mm/mem_sharing.c | 1 - 1 file changed, 1 deletion(-)