| Message ID | 20231019171452.1704276-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for-4.18] CI: (More) Always pull base image when building a container | expand |
On Thu, Oct 19, 2023 at 06:14:52PM +0100, Andrew Cooper wrote: > Repeat c/s 26ecc08b98fc ("automation: Always pull base image when building a > container") for the other makefile we've got building containers. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > --- > > For 4.18. This is CI infrastructure, not part of the regular build. Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> Thanks,
On Thu, 19 Oct 2023, Anthony PERARD wrote: > On Thu, Oct 19, 2023 at 06:14:52PM +0100, Andrew Cooper wrote: > > Repeat c/s 26ecc08b98fc ("automation: Always pull base image when building a > > container") for the other makefile we've got building containers. > > > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > > --- > > > > For 4.18. This is CI infrastructure, not part of the regular build. > > Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Hi all, > On Oct 20, 2023, at 03:43, Stefano Stabellini <sstabellini@kernel.org> wrote: > > On Thu, 19 Oct 2023, Anthony PERARD wrote: >> On Thu, Oct 19, 2023 at 06:14:52PM +0100, Andrew Cooper wrote: >>> Repeat c/s 26ecc08b98fc ("automation: Always pull base image when building a >>> container") for the other makefile we've got building containers. >>> >>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> >>> --- >>> >>> For 4.18. This is CI infrastructure, not part of the regular build. >> >> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> > > Acked-by: Stefano Stabellini <sstabellini@kernel.org> Release-acked-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry
diff --git a/automation/tests-artifacts/Makefile b/automation/tests-artifacts/Makefile index 8ca71b78adbd..d055cd696bed 100644 --- a/automation/tests-artifacts/Makefile +++ b/automation/tests-artifacts/Makefile @@ -10,7 +10,7 @@ help: @echo "To push container builds, set the env var PUSH" %: %.dockerfile ## Builds containers - docker build -t $(REGISTRY)/$(@D):$(@F) -f $< $(<D) + docker build --pull -t $(REGISTRY)/$(@D):$(@F) -f $< $(<D) @if [ ! -z $${PUSH+x} ]; then \ docker push $(REGISTRY)/$(@D):$(@F); \ fi
Repeat c/s 26ecc08b98fc ("automation: Always pull base image when building a container") for the other makefile we've got building containers. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Anthony PERARD <anthony.perard@citrix.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Michal Orzel <michal.orzel@amd.com> CC: Doug Goldstein <cardoe@cardoe.com> CC: Henry Wang <Henry.Wang@arm.com> For 4.18. This is CI infrastructure, not part of the regular build. --- automation/tests-artifacts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 698b0f5031c6083401234a9b9415175cc5855a0a prerequisite-patch-id: 94c86c1b3eb7aeda8eeef91241cdc8fa2691e2bc prerequisite-patch-id: 728853399bfbaf972317a0d35ecd695f65026844 prerequisite-patch-id: 5a145a4decd44ace43a37b0315773e0abc6d54c6 prerequisite-patch-id: 24fad994d25558a45bbd3ead38120c154a974e9a prerequisite-patch-id: a2a69b5382a293809a03633fd0513c371f9cf668