| Message ID | 20240205104740.14905-1-frediano.ziglio@cloud.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/5] Constify some parameters | expand |
On 05.02.2024 11:47, Frediano Ziglio wrote: > __HYPERVISOR_arch_1 and __HYPERVISOR_paging_domctl_cont for x86 > have the same value but this function is handling > "paging_domctl_cont" hypercall so using the latter mnemonic in > the code is more clear. > > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> I can't reconstruct why it was done like this. arch_do_domctl() uses the "more specific" constant in any case. Jan
diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 541c2ea9b2..2961ca734d 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -783,7 +783,7 @@ long do_paging_domctl_cont( rcu_unlock_domain(d); if ( ret == -ERESTART ) - ret = hypercall_create_continuation(__HYPERVISOR_arch_1, + ret = hypercall_create_continuation(__HYPERVISOR_paging_domctl_cont, "h", u_domctl); else if ( __copy_field_to_guest(u_domctl, &op, u.shadow_op) ) ret = -EFAULT;
__HYPERVISOR_arch_1 and __HYPERVISOR_paging_domctl_cont for x86 have the same value but this function is handling "paging_domctl_cont" hypercall so using the latter mnemonic in the code is more clear. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com> --- xen/arch/x86/mm/paging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)