diff mbox series

[4/4] x86: Drop mach_mpspec.h

Message ID 20241108201147.812036-5-andrew.cooper3@citrix.com (mailing list archive)
State New
Headers show
Series Untangle mach-default/ | expand

Commit Message

Andrew Cooper Nov. 8, 2024, 8:11 p.m. UTC 
This header is included in exactly one location.  Fold it into mpspec.h

With this done, mach-default/ is empty, so remove the include path.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/arch.mk                                |  1 -
 xen/arch/x86/include/asm/mach-default/mach_mpspec.h | 10 ----------
 xen/arch/x86/include/asm/mpspec.h                   |  4 +++-
 3 files changed, 3 insertions(+), 12 deletions(-)
 delete mode 100644 xen/arch/x86/include/asm/mach-default/mach_mpspec.h

Comments

Jan Beulich Nov. 11, 2024, 9:23 a.m. UTC | #1 
On 08.11.2024 21:11, Andrew Cooper wrote:
> --- a/xen/arch/x86/include/asm/mach-default/mach_mpspec.h
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -#ifndef __ASM_MACH_MPSPEC_H
> -#define __ASM_MACH_MPSPEC_H
> -
> -#define MAX_IRQ_SOURCES 256
> -
> -/* Generic (i.e. installer) kernels need lots of bus entries. */
> -/* Maximum 256 PCI busses, plus 1 ISA bus in each of 4 cabinets. */

This (presumably obsolete, but still) reasoning is entirely lost ...

> -#define MAX_MP_BUSSES 260
> -
> -#endif /* __ASM_MACH_MPSPEC_H */
> --- a/xen/arch/x86/include/asm/mpspec.h
> +++ b/xen/arch/x86/include/asm/mpspec.h
> @@ -3,7 +3,9 @@
>  
>  #include <xen/cpumask.h>
>  #include <asm/mpspec_def.h>
> -#include <mach_mpspec.h>
> +
> +#define MAX_IRQ_SOURCES 256
> +#define MAX_MP_BUSSES 260

... for why it's 260 here. Imo the value either wants lowering to 256
(for there hardly being anything ISAish in 64-bit systems), or at least
that half of the comment retaining.

Jan
diff mbox series

Patch

diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
index 8f8aeda679d8..80b4431c8906 100644
--- a/xen/arch/x86/arch.mk
+++ b/xen/arch/x86/arch.mk
@@ -3,7 +3,6 @@ 
 
 export XEN_IMG_OFFSET := 0x200000
 
-CFLAGS += -I$(srctree)/arch/x86/include/asm/mach-default
 CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFFSET)
 
 # Prevent floating-point variables from creeping into Xen.
diff --git a/xen/arch/x86/include/asm/mach-default/mach_mpspec.h b/xen/arch/x86/include/asm/mach-default/mach_mpspec.h
deleted file mode 100644
index 1a4e3f8c4f35..000000000000
--- a/xen/arch/x86/include/asm/mach-default/mach_mpspec.h
+++ /dev/null
@@ -1,10 +0,0 @@ 
-#ifndef __ASM_MACH_MPSPEC_H
-#define __ASM_MACH_MPSPEC_H
-
-#define MAX_IRQ_SOURCES 256
-
-/* Generic (i.e. installer) kernels need lots of bus entries. */
-/* Maximum 256 PCI busses, plus 1 ISA bus in each of 4 cabinets. */
-#define MAX_MP_BUSSES 260
-
-#endif /* __ASM_MACH_MPSPEC_H */
diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h
index 45e474dfd1b6..267768e7595e 100644
--- a/xen/arch/x86/include/asm/mpspec.h
+++ b/xen/arch/x86/include/asm/mpspec.h
@@ -3,7 +3,9 @@ 
 
 #include <xen/cpumask.h>
 #include <asm/mpspec_def.h>
-#include <mach_mpspec.h>
+
+#define MAX_IRQ_SOURCES 256
+#define MAX_MP_BUSSES 260
 
 extern unsigned char mp_bus_id_to_type[MAX_MP_BUSSES];