diff mbox series

[v2,02/35] xen/irq: introduce NO_IRQ

Message ID 20241205-vuart-ns8250-v1-2-e9aa923127eb@ford.com (mailing list archive)
State New
Headers show
Series Introduce NS8250 UART emulator | expand

Commit Message

Denis Mukhin via B4 Relay Dec. 6, 2024, 4:41 a.m. UTC 
From: Denis Mukhin <dmukhin@ford.com>

Introduce definition for IRQ resource checks.

Signed-off-by: Denis Mukhin <dmukhin@ford.com>
---
 xen/include/xen/irq.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Beulich Dec. 10, 2024, 1:17 p.m. UTC | #1 
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote:
> From: Denis Mukhin <dmukhin@ford.com>
> 
> Introduce definition for IRQ resource checks.

How does this fit ...

> --- a/xen/include/xen/irq.h
> +++ b/xen/include/xen/irq.h
> @@ -53,6 +53,7 @@ struct irqaction {
>  #define AUTO_ASSIGN_IRQ         (-1)
>  #define NEVER_ASSIGN_IRQ        (-2)
>  #define FREE_TO_ASSIGN_IRQ      (-3)
> +#define NO_IRQ                  (-4)

... the grouping here? The constants in context aren't used anywhere,
so it's hard to see whether / how the new one fits here (and doesn't
instead belong into the new resource.h you introduce in patch 1). Once
again likely best to have this in the patch where it's first needed,
thus providing at least some context.

Jan
diff mbox series

Patch

diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h
index 95034c0d6bb5f0aa7d5bb572aca59872508a438a..aee878293ecc0de6a938bcfea1140d36b4de745a 100644
--- a/xen/include/xen/irq.h
+++ b/xen/include/xen/irq.h
@@ -53,6 +53,7 @@  struct irqaction {
 #define AUTO_ASSIGN_IRQ         (-1)
 #define NEVER_ASSIGN_IRQ        (-2)
 #define FREE_TO_ASSIGN_IRQ      (-3)
+#define NO_IRQ                  (-4)
 
 struct irq_desc;