| Message ID | 20241205195026.3523-1-jason.andryuk@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | CHANGELOG: Mention xl suspend/resume | expand |
On 05.12.2024 20:50, Jason Andryuk wrote: > Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> > --- > It only works for x86, but it isn't x86-specific. I chose to add it as > a generic entry instead of listing it as x86. Which probably is fine, yet then ... > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > ### Added > - On Arm: > - Experimental support for Armv8-R. > + - xl suspend/resume subcommands. ... you'd want to name the limitation to x86 here anyway, I think. Unless there are firm plans to remove the limitation by 4.20 going out. Jan
On 2024-12-09 04:29, Jan Beulich wrote: > On 05.12.2024 20:50, Jason Andryuk wrote: >> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> >> --- >> It only works for x86, but it isn't x86-specific. I chose to add it as >> a generic entry instead of listing it as x86. > > Which probably is fine, yet then ... > >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >> ### Added >> - On Arm: >> - Experimental support for Armv8-R. >> + - xl suspend/resume subcommands. > > ... you'd want to name the limitation to x86 here anyway, I think. Unless > there are firm plans to remove the limitation by 4.20 going out. No, I don't think there are any plans to remove the limitation. This seems weird since the feature depends on platform implementations of hypercalls and library plumbing: - On x86: - xl suspend/resume subcommands. Whereas this seems unusual since it's not following the above format: - xl suspend/resume subcommands (x86 only). I guess I'd put it under "On x86" if I had to choose. Regards, Jason
On 09.12.2024 20:20, Jason Andryuk wrote: > On 2024-12-09 04:29, Jan Beulich wrote: >> On 05.12.2024 20:50, Jason Andryuk wrote: >>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> >>> --- >>> It only works for x86, but it isn't x86-specific. I chose to add it as >>> a generic entry instead of listing it as x86. >> >> Which probably is fine, yet then ... >> >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> ### Added >>> - On Arm: >>> - Experimental support for Armv8-R. >>> + - xl suspend/resume subcommands. >> >> ... you'd want to name the limitation to x86 here anyway, I think. Unless >> there are firm plans to remove the limitation by 4.20 going out. > > No, I don't think there are any plans to remove the limitation. > > This seems weird since the feature depends on platform implementations of hypercalls and library plumbing: > > - On x86: > - xl suspend/resume subcommands. > > Whereas this seems unusual since it's not following the above format: > > - xl suspend/resume subcommands (x86 only). > > I guess I'd put it under "On x86" if I had to choose. I'd be fine with either; neither looks more "weird" to me than the other. Jan
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8553b2e451..5e912b3759 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Added - On Arm: - Experimental support for Armv8-R. + - xl suspend/resume subcommands. ### Removed - On x86:
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> --- It only works for x86, but it isn't x86-specific. I chose to add it as a generic entry instead of listing it as x86. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+)